Update patch set 1

Patch Set 1:

(7 comments)

Patch-set: 1
Reviewer: Pau Espin Pedrol <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=0

ea797ca92816bc9fbc8220c64813e1a040f8be76

@@ -17,6 +17,24 @@
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "fa98f980_5858b5fa",
+        "filename": "src/osmo_gsm_tester/ofono_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 116,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2017-05-02T12:00:29Z",
+      "side": 1,
+      "message": "Agree",
+      "parentUuid": "fa98f980_587c3573",
+      "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "fa98f980_d88f4574",
@@ -34,6 +52,24 @@
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "fa98f980_78465925",
+        "filename": "src/osmo_gsm_tester/ofono_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 129,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2017-05-02T12:00:29Z",
+      "side": 1,
+      "message": "Makes sense",
+      "parentUuid": "fa98f980_d88f4574",
+      "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "fa98f980_f88c0982",
@@ -51,6 +87,24 @@
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "fa98f980_984a1d26",
+        "filename": "src/osmo_gsm_tester/ofono_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 138,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2017-05-02T12:00:29Z",
+      "side": 1,
+      "message": "Yes, they are string tokens defined by ofono, see: https://github.com/intgr/ofono/blob/master/doc/network-api.txt#L78\n\nNot sure if it\u0027s that worth moving it into a constant as I would expect it not to change anyway.",
+      "parentUuid": "fa98f980_f88c0982",
+      "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "fa98f980_38ee9123",
@@ -68,6 +122,24 @@
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "fa98f980_b847e11c",
+        "filename": "src/osmo_gsm_tester/ofono_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 140,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2017-05-02T12:00:29Z",
+      "side": 1,
+      "message": "I agree. I can create a 2nd patch to do the connect()-\u003eregister()",
+      "parentUuid": "fa98f980_38ee9123",
+      "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "fa98f980_18e9cd1a",
@@ -85,6 +157,24 @@
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "fa98f980_d854a5cc",
+        "filename": "src/osmo_gsm_tester/ofono_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 148,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2017-05-02T12:00:29Z",
+      "side": 1,
+      "message": "Yes, this is not really detailed but for now it\u0027s enough. Even in connect() we should actually pass some Network code to which we should be connecting to, or None in case we want to use auto + default network. Then we should use all the Operator API from ofono, but I think all this can wait for later steps and for now consider we always try to connect automatically to default network.",
+      "parentUuid": "fa98f980_18e9cd1a",
+      "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "fa98f980_58f3550a",
@@ -102,6 +192,24 @@
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "fa98f980_f85169d9",
+        "filename": "src/osmo_gsm_tester/ofono_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 154,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2017-05-02T12:00:29Z",
+      "side": 1,
+      "message": "Do you think is really an issue? it\u0027s not like it\u0027s taking seconds to do it.",
+      "parentUuid": "fa98f980_58f3550a",
+      "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "fa98f980_78f819e6",
@@ -118,6 +226,24 @@
       "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa98f980_3863f1b2",
+        "filename": "src/osmo_gsm_tester/ofono_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 156,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2017-05-02T12:00:29Z",
+      "side": 1,
+      "message": "Agree. I will use RuntimeError for now.",
+      "parentUuid": "fa98f980_78f819e6",
+      "revId": "ea797ca92816bc9fbc8220c64813e1a040f8be76",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
     }
   ]
 }