Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000004 2024-02-27 08:28:44 +00:00 committed by Gerrit Code Review
parent d679ef1b62
commit eb61fe654a
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "54231f18_445edb2d",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 18,
"author": {
"id": 1000004
},
"writtenOn": "2024-02-27T08:28:44Z",
"side": 1,
"message": "Does this make sense? We\u0027re only talking about in-tree users of those header files within osmo-ggsn.git right? External users of the libgtp API would always have used those headers from include/osmocom/gtp installed on their system, right?\n\nIf my assumptions are true, I don\u0027t think it is a good idea to add compat wrapper files. just update all the source #include statements in this repository and be done with it?",
"range": {
"startLine": 17,
"startChar": 0,
"endLine": 18,
"endChar": 35
},
"revId": "fe9bb72bdd18d1532250c9ae096134a347558b9f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}