cellular-infrastructure
/
osmo-gbproxy
mirror of https://gerrit.osmocom.org/osmo-gbproxy
9
0
Fork 0
Code Issues Releases Wiki Activity

Fix earfcn deletion 

* fix typo in arg index
* fix sign in error reporting
* add vty test
This commit is contained in:
Max 2016-04-20 12:06:06 +02:00 committed by Harald Welte
parent 303753ec6b
commit 2befab15f4
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openbsc/src/libbsc/bsc_vty.c
View File

@ -2802,11 +2802,11 @@ DEFUN(cfg_bts_si2quater_neigh_del, cfg_bts_si2quater_neigh_del_cmd,
{
struct gsm_bts *bts = vty->index;
struct osmo_earfcn_si2q *e = &bts->si_common.si2quater_neigh_list;
uint16_t arfcn = atoi(argv[1]);
uint16_t arfcn = atoi(argv[0]);
int r = osmo_earfcn_del(e, arfcn);
if (r < 0) {
vty_out(vty, "Unable to delete arfcn %u: %s%s", arfcn,
strerror(r), VTY_NEWLINE);
strerror(-r), VTY_NEWLINE);
return CMD_WARNING;
}

14
openbsc/tests/vty_test_runner.py
View File

@ -231,6 +231,20 @@ class TestVTYNITB(TestVTYGenericBSC):
self.assertEquals(self.vty.node(), 'config-mncc-int')
def testSi2Q(self):
self.vty.enable()
self.vty.command("configure terminal")
self.vty.command("network")
self.vty.command("bts 0")
before = self.vty.command("show running-config")
self.vty.command("si2quater neighbor-list add earfcn 1911 threshold 11 2")
self.vty.command("si2quater neighbor-list add earfcn 1924 threshold 11 3")
self.vty.command("si2quater neighbor-list add earfcn 2111 threshold 11")
self.vty.command("si2quater neighbor-list del earfcn 1911")
self.vty.command("si2quater neighbor-list del earfcn 1924")
self.vty.command("si2quater neighbor-list del earfcn 2111")
self.assertEquals(before, self.vty.command("show running-config"))
def testEnableDisablePeriodicLU(self):
self.vty.enable()
self.vty.command("configure terminal")