cellular-infrastructure
/
osmo-gbproxy
mirror of https://gerrit.osmocom.org/osmo-gbproxy
9
0
Fork 0
Code Issues Releases Wiki Activity

gtphub: improve logging for invalid packet 

Sponsored-by: On-Waves ehi
This commit is contained in:
Neels Hofmeyr 2015-12-03 11:25:27 +01:00
parent 84d7686c1d
commit 06883a4208
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
openbsc/src/gprs/gtphub.c
View File

@ -503,10 +503,8 @@ static void gtp_decode(const uint8_t *data, int data_len,
validate_gtp_header(res);
if (res->rc <= 0) {
LOG(LOGL_ERROR, "INVALID: dropping GTP packet.\n");
if (res->rc <= 0)
return;
}
LOG(LOGL_DEBUG, "Valid GTP header (v%d)\n", res->version);
@ -2064,8 +2062,13 @@ int gtphub_handle_buf(struct gtphub *hub,
struct gtp_packet_desc p;
gtp_decode(buf, received, side_idx, plane_idx, &p, now);
if (p.rc <= 0)
if (p.rc <= 0) {
LOG(LOGL_ERROR, "INVALID: dropping GTP packet from %s %s %s\n",
gtphub_side_idx_names[side_idx],
gtphub_plane_idx_names[plane_idx],
osmo_sockaddr_to_str(from_addr));
return -1;
}
rate_ctr_inc(&from_bind->counters_io->ctr[GTPH_CTR_PKTS_IN]);