cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

l1sap: fix: enable UL SACCH repetition if RxQual threshold is 0 

It is expected that setting RxQual threshold to 0 would make the
L1SAP logic enable repetition for both Uplink SACCH and Downlink
FACCH unconditionally.  However, this was only valid for the
later.  Let's add the missing check and make it consistent.

Change-Id: Ia44a134e7f28ea990798d1b79c87b644504c0876
Related: SYS#5114
This commit is contained in:
Vadim Yanitskiy 2021-01-04 21:46:00 +01:00
parent 763ce0627a
commit e476629bcf
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/common/l1sap.c
View File

@ -1408,6 +1408,12 @@ static void repeated_ul_sacch_active_decision(struct gsm_lchan *lchan,
if (!lchan->repeated_acch_capability.ul_sacch)
return;
/* Threshold disabled (repetition is always on) */
if (lchan->repeated_acch_capability.rxqual == 0) {
lchan->repeated_ul_sacch_active = true;
return;
}
/* convert from RXQUAL value to ber10k vale,
* see also GSM 05.08, section 8.2.4 */
static const uint16_t ber10k_by_rxqual_upper[] =