cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

OML: fix memory leaks by centralized msgb_free() for rx msgs

This commit is contained in:
Harald Welte 2011-06-29 18:57:58 +02:00
parent ae5dfdc416
commit 40e820d882
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/common/oml.c
View File

@ -717,7 +717,6 @@ static int down_fom(struct gsm_bts *bts, struct msgb *msg)
if (msgb_l2len(msg) < sizeof(*foh)) {
LOGP(DOML, LOGL_NOTICE, "Formatted O&M message too short\n");
msgb_free(msg);
return -EIO;
}
@ -822,7 +821,6 @@ static int down_mom(struct gsm_bts *bts, struct msgb *msg)
if (msgb_l2len(msg) < sizeof(*foh)) {
LOGP(DOML, LOGL_NOTICE, "Manufacturer O&M message too short\n");
msgb_free(msg);
return -EIO;
}
@ -879,7 +877,6 @@ int down_oml(struct gsm_bts *bts, struct msgb *msg)
case ABIS_OM_MDISC_FOM:
if (msgb_l2len(msg) < sizeof(*oh)) {
LOGP(DOML, LOGL_NOTICE, "Formatted O&M message too short\n");
msgb_free(msg);
ret = -EIO;
break;
}
@ -888,7 +885,6 @@ int down_oml(struct gsm_bts *bts, struct msgb *msg)
case ABIS_OM_MDISC_MANUF:
if (msgb_l2len(msg) < sizeof(*oh)) {
LOGP(DOML, LOGL_NOTICE, "Manufacturer O&M message too short\n");
msgb_free(msg);
ret = -EIO;
break;
}
@ -897,10 +893,11 @@ int down_oml(struct gsm_bts *bts, struct msgb *msg)
default:
LOGP(DOML, LOGL_NOTICE, "unknown OML msg_discr 0x%02x\n",
oh->mdisc);
msgb_free(msg);
ret = -EINVAL;
}
msgb_free(msg);
return ret;
}