128 lines
3.6 KiB
Plaintext
128 lines
3.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e1fd827b_a6a45626",
|
|
"filename": "src/osmo-bsc/bts_ctrl.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 375,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2024-01-15T18:18:19Z",
|
|
"side": 1,
|
|
"message": "The command is called `oml-uptime`.\nMaybe emulate the old behavior here (like you do in `bts_store_uptime()`)?",
|
|
"range": {
|
|
"startLine": 375,
|
|
"startChar": 43,
|
|
"endLine": 375,
|
|
"endChar": 57
|
|
},
|
|
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1883bbd8_d43bb3d1",
|
|
"filename": "src/osmo-bsc/bts_ctrl.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 375,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2024-01-18T08:58:52Z",
|
|
"side": 1,
|
|
"message": "Ack",
|
|
"parentUuid": "e1fd827b_a6a45626",
|
|
"range": {
|
|
"startLine": 375,
|
|
"startChar": 43,
|
|
"endLine": 375,
|
|
"endChar": 57
|
|
},
|
|
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "169b81f7_abd73267",
|
|
"filename": "src/osmo-bsc/bts_ctrl.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 375,
|
|
"author": {
|
|
"id": 1000231
|
|
},
|
|
"writtenOn": "2024-01-19T10:00:33Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "1883bbd8_d43bb3d1",
|
|
"range": {
|
|
"startLine": 375,
|
|
"startChar": 43,
|
|
"endLine": 375,
|
|
"endChar": 57
|
|
},
|
|
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d8b99b78_3195d22d",
|
|
"filename": "src/osmo-bsc/bts_ipaccess_nanobts.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 763,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-01-15T10:04:19Z",
|
|
"side": 1,
|
|
"message": "Looks like you probably want to add the downtime count here instead of ipaccess_drop_oml()? What if the links goes down due to some other path different than ipaccess_drop_oml()?",
|
|
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2bb98965_0121496b",
|
|
"filename": "src/osmo-bsc/bts_ipaccess_nanobts.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 763,
|
|
"author": {
|
|
"id": 1000231
|
|
},
|
|
"writtenOn": "2024-01-15T11:09:05Z",
|
|
"side": 1,
|
|
"message": "ipaccess_sign_link_down() calls ipaccess_drop_oml() in any case.\nipaccess_sign_link_down() acquires the BTS pointer from the link that went down.",
|
|
"parentUuid": "d8b99b78_3195d22d",
|
|
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "297a2adb_70fed4c3",
|
|
"filename": "src/osmo-bsc/bts_ipaccess_nanobts.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 763,
|
|
"author": {
|
|
"id": 1000231
|
|
},
|
|
"writtenOn": "2024-01-19T10:00:33Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "2bb98965_0121496b",
|
|
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |