osmo-bsc/openbsc/src
Holger Hans Peter Freyther 46edbc4162 lchan: Release channel in case of late activation ack
In case of the sysmoBTS and receiving a channel activation ack on a channel
that was marked as broken, release it again.

Use a normal release without SACCH deactivation and release the rqd_ta data.

Also add a local variable 'ts' to shorten some lines.

The typical situation where this would occur is with high latency between BTS
and BSC (or NITB). If a channel activation ack does not arrive in time, a
channel is marked broken, and never recovers after that. This patch will
release the channel again, which will remove the BROKEN_UNUSABLE state and
makes lchan available again. Reported by Rhizomatica.

However, in case of packet loss, i.e. when the channel activation ack never
arrives at the BSC, this patch does not provide a resolution of the
BROKEN_UNUSABLE state.

On dynamic timeslots: clearing the dyn ts state could possibly happen in
lchan_free() instead of in rsl_rx_chan_act_ack(). That's to be done in a
separate patch, if at all.

Tweaked-By: nhofmeyr
Change-Id: I63dc0deaf15ba7c21e20b1e0c7b85f0437e183ed
2016-11-09 15:43:13 +00:00
..
gprs SGSN: Use dummy all-zero MSISDN value in PDP Context Act on GTP 2016-11-09 15:42:39 +00:00
ipaccess msgb talloc ctx: initialize in all main() scopes 2016-10-13 13:14:41 +00:00
libbsc lchan: Release channel in case of late activation ack 2016-11-09 15:43:13 +00:00
libcommon Replace magic number with define 2016-10-18 16:19:33 +02:00
libfilter Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00
libiu info log: iu: add line break to and tweak rx RAB Ass Resp log 2016-10-30 18:28:27 +00:00
libmgcp COSMETIC: 'if' is not a function, so there is space before '(' 2016-09-28 00:47:28 +00:00
libmsc mncc_builtin: Properly reject DTMF 2016-11-02 09:20:54 +00:00
libtrau Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00
osmo-bsc msgb talloc ctx: initialize in all main() scopes 2016-10-13 13:14:41 +00:00
osmo-bsc_mgcp msgb talloc ctx: initialize in all main() scopes 2016-10-13 13:14:41 +00:00
osmo-bsc_nat msgb ctx: use new msgb_talloc_ctx_init(), don't access talloc_msgb_ctx 2016-10-13 13:14:41 +00:00
osmo-nitb Cosmetic: Add missing switch to usage help 2016-11-01 21:56:23 +00:00
utils msgb talloc ctx: initialize in all main() scopes 2016-10-13 13:14:41 +00:00
Makefile.am Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00