osmo-bsc/dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "69b475df_cf9f8d5f",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 7,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-01-30T20:07:40Z",
      "side": 1,
      "message": "Please add at least a brief description for the command(s) you\u0027re adding. Something like: \"this new command allows you to control MS power level for a specific logical channel\".\n\nI would also point out that the effect of this command may differ depending on whether you have `static` or `dynamic` MS power control. For `static` it would instruct the MS to transmit at the requested power level. However, for `dynamic` it would simply limit the maximum power level and not necessarily affect the actual MS power level.",
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "d87fa669_1192a170",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 7,
      "author": {
        "id": 1000236
      },
      "writtenOn": "2024-01-31T08:07:18Z",
      "side": 1,
      "message": "The effect is critical so it was added in a comment in the code",
      "parentUuid": "69b475df_cf9f8d5f",
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1b529b9d_4b01533a",
        "filename": "src/osmo-bsc/bts_trx_ts_lchan_ctrl.c",
        "patchSetId": 3
      },
      "lineNbr": 3,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-01-30T20:07:40Z",
      "side": 1,
      "message": "looks like you\u0027re missing to update the copyright header",
      "range": {
        "startLine": 2,
        "startChar": 0,
        "endLine": 3,
        "endChar": 20
      },
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "cf1c214b_abebefb7",
        "filename": "src/osmo-bsc/bts_trx_ts_lchan_ctrl.c",
        "patchSetId": 3
      },
      "lineNbr": 3,
      "author": {
        "id": 1000236
      },
      "writtenOn": "2024-01-31T08:07:18Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "1b529b9d_4b01533a",
      "range": {
        "startLine": 2,
        "startChar": 0,
        "endLine": 3,
        "endChar": 20
      },
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "0ef548bf_71d17c53",
        "filename": "src/osmo-bsc/bts_trx_ts_lchan_ctrl.c",
        "patchSetId": 3
      },
      "lineNbr": 3,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-02-14T10:40:52Z",
      "side": 1,
      "message": "I am not a Copyright expert, but this still does not look right to me. If this is the code you wrote, you should put your name and E-mail in the copyright header. It\u0027s usually Sysmocom employees who put `by sysmocom s.f.m.c. GmbH` here.",
      "parentUuid": "cf1c214b_abebefb7",
      "range": {
        "startLine": 2,
        "startChar": 0,
        "endLine": 3,
        "endChar": 20
      },
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "abde2d43_8f1cb38c",
        "filename": "src/osmo-bsc/bts_trx_ts_lchan_ctrl.c",
        "patchSetId": 3
      },
      "lineNbr": 3,
      "author": {
        "id": 1000236
      },
      "writtenOn": "2024-02-14T10:58:40Z",
      "side": 1,
      "message": "I am not an expert either, I thought that since it is an osmocom project, sysmocom should have the copyright (I am only contributing it) - I will replace with my name",
      "parentUuid": "0ef548bf_71d17c53",
      "range": {
        "startLine": 2,
        "startChar": 0,
        "endLine": 3,
        "endChar": 20
      },
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f134f613_a328c67a",
        "filename": "src/osmo-bsc/bts_trx_ts_lchan_ctrl.c",
        "patchSetId": 3
      },
      "lineNbr": 18,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-02-14T10:40:52Z",
      "side": 1,
      "message": "No need to remove this whole part.",
      "range": {
        "startLine": 17,
        "startChar": 0,
        "endLine": 18,
        "endChar": 1
      },
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "53ce488c_be23b602",
        "filename": "src/osmo-bsc/bts_trx_ts_lchan_ctrl.c",
        "patchSetId": 3
      },
      "lineNbr": 18,
      "author": {
        "id": 1000236
      },
      "writtenOn": "2024-02-14T10:58:40Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "f134f613_a328c67a",
      "range": {
        "startLine": 17,
        "startChar": 0,
        "endLine": 18,
        "endChar": 1
      },
      "revId": "dbd4afc9e7b0c7c0e6ee7a914a089621735f8a71",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}