cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

HO: cfg: tweak vty write 

Have expicitly named vty write functions for bts and net levels, so that it is
trivial to add commands that exist only on one of each (like the upcoming
congestion check timer config for hodec2).

Change-Id: Ibea4c20abc50c3d655f6bbb1a643477dfc722c8e
This commit is contained in:
Neels Hofmeyr 2018-02-12 16:48:45 +01:00
parent a60f344212
commit dfd36da120
3 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/osmocom/bsc/handover_vty.h
View File

@ -4,4 +4,5 @@
#include <osmocom/bsc/handover_cfg.h>
void ho_vty_init();
void ho_vty_write(struct vty *vty, const char *indent, struct handover_cfg *ho);
void ho_vty_write_net(struct vty *vty, struct gsm_network *net);
void ho_vty_write_bts(struct vty *vty, struct gsm_bts *bts);

4
src/libbsc/bsc_vty.c
View File

@ -822,7 +822,7 @@ static void config_write_bts_single(struct vty *vty, struct gsm_bts *bts)
if (bts->pcu_sock_path)
vty_out(vty, " pcu-socket %s%s", bts->pcu_sock_path, VTY_NEWLINE);
ho_vty_write(vty, " ", bts->ho);
ho_vty_write_bts(vty, bts);
config_write_bts_model(vty, bts);
}
@ -854,7 +854,7 @@ static int config_write_net(struct vty *vty)
vty_out(vty, " neci %u%s", gsmnet->neci, VTY_NEWLINE);
vty_out(vty, " paging any use tch %d%s", gsmnet->pag_any_tch, VTY_NEWLINE);
ho_vty_write(vty, " ", gsmnet->ho);
ho_vty_write_net(vty, gsmnet);
VTY_OUT_TIMER(3101);
VTY_OUT_TIMER(3103);

14
src/libbsc/handover_vty.c
View File

@ -70,7 +70,7 @@ HO_CFG_ALL_MEMBERS
#undef HO_CFG_ONE_MEMBER
void ho_vty_write(struct vty *vty, const char *indent, struct handover_cfg *ho)
static void ho_vty_write(struct vty *vty, const char *indent, struct handover_cfg *ho)
{
#define HO_CFG_ONE_MEMBER(TYPE, NAME, DEFAULT_VAL, \
VTY_CMD, VTY_CMD_ARG, VTY_ARG_EVAL, \
@ -84,6 +84,18 @@ void ho_vty_write(struct vty *vty, const char *indent, struct handover_cfg *ho)
#undef HO_CFG_ONE_MEMBER
}
void ho_vty_write_bts(struct vty *vty, struct gsm_bts *bts)
{
ho_vty_write(vty, " ", bts->ho);
}
void ho_vty_write_net(struct vty *vty, struct gsm_network *net)
{
ho_vty_write(vty, " ", net->ho);
/* future: net specific vty commands */
}
static void ho_vty_init_cmds(int parent_node)
{
#define HO_CFG_ONE_MEMBER(TYPE, NAME, DEFAULT_VAL, VTY1, VTY2, VTY3, VTY4, VTY5, VTY6) \