cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

gsm_bts_check_ny1: Prevent possible division by zero 

Do this by setting the minimal value for T3105 to 1 in its timer definition.

Fixes: Coverity scan CID#307389
Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad
This commit is contained in:
arehbein 2023-03-18 23:54:13 +01:00 committed by laforge
parent 64c0e6e11c
commit d7b277ff01
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/osmo-bsc/net_init.c
View File

@ -36,7 +36,7 @@ static struct osmo_tdef gsm_network_T_defs[] = {
{ .T = 101, .default_val = 10, .desc = "inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept" },
{ .T = 3101, .default_val = 3, .desc = "RR Immediate Assignment" },
{ .T = 3103, .default_val = 5, .desc = "Handover" },
{ .T = 3105, .default_val = GSM_T3105_DEFAULT, .unit = OSMO_TDEF_MS, .desc = "Physical Information" },
{ .T = 3105, .default_val = GSM_T3105_DEFAULT, .min_val = 1, .unit = OSMO_TDEF_MS, .desc = "Physical Information" },
{ .T = 3107, .default_val = 5, .desc = "(unused)" },
{ .T = 3109, .default_val = 5, .desc = "RSL SACCH deactivation" },
{ .T = 3111, .default_val = 2, .desc = "Wait time before RSL RF Channel Release" },

4
tests/timer.vty
View File

@ -8,7 +8,7 @@ net: T10 = 6 s RR Assignment (default: 6 s)
net: T101 = 10 s inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept (default: 10 s)
net: T3101 = 3 s RR Immediate Assignment (default: 3 s)
net: T3103 = 5 s Handover (default: 5 s)
net: T3105 = 100 ms Physical Information (default: 100 ms)
net: T3105 = 100 ms Physical Information (default: 100 ms, range: [1 .. inf])
net: T3107 = 5 s (unused) (default: 5 s)
net: T3109 = 5 s RSL SACCH deactivation (default: 5 s)
net: T3111 = 2 s Wait time before RSL RF Channel Release (default: 2 s)
@ -64,7 +64,7 @@ net: T10 = 6 s RR Assignment (default: 6 s)
net: T101 = 10 s inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept (default: 10 s)
net: T3101 = 3 s RR Immediate Assignment (default: 3 s)
net: T3103 = 5 s Handover (default: 5 s)
net: T3105 = 100 ms Physical Information (default: 100 ms)
net: T3105 = 100 ms Physical Information (default: 100 ms, range: [1 .. inf])
net: T3107 = 5 s (unused) (default: 5 s)
net: T3109 = 5 s RSL SACCH deactivation (default: 5 s)
net: T3111 = 2 s Wait time before RSL RF Channel Release (default: 2 s)