cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

WIP: fsms: use configurable timers instead of T23042 

It looks like T23042 was a placeholder for timers to be filled in later,
it cannot be configured via VTY and I cannot find it mentioned in any
specs on etsi.org. git blame shows it first appeard in 31f525e ("large
refactoring: use FSMs for lchans; add inter-BSC HO"). Replace T23042
with timers that can be configured via VTY.

Previous timeout for the states was 5s.

* ASSIGNMENT_ST_WAIT_MGW_ENDPOINT_TO_MSC and
  HO_ST_WAIT_MGW_ENDPOINT_TO_MSC:
  * Runs gscon_connect_mgw_to_msc() on enter, which waits for one MGCP
    CRCX or MDCX response (or changes state immediatelly)
  * Use existing X9 ("Timeout for availability of MGW endpoint"), 5s,
    which was previously being used by lchan_rtp_fsm for a similar
    purpuse

* HO_ST_WAIT_LCHAN_ACTIVE:
  * Runs lchan_activate() on enter, and waits for the lchan fsm to go
    through LCHAN_ST_WAIT_TS_READY (X5) and LCHAN_ST_WAIT_ACTIV_ACK
    (X6).
  * Use new X29, 10s (5s from X5 + 5s from X6)

Change-Id: Id0d4d0788f609f3272fc81c80a754383dde25c16
This commit is contained in:
Oliver Smith 2022-11-25 10:56:35 +01:00
parent 346c6011bc
commit d27f8a33dd
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/osmo-bsc/assignment_fsm.c
View File

@ -54,7 +54,7 @@ static const struct osmo_tdef_state_timeout assignment_fsm_timeouts[32] = {
[ASSIGNMENT_ST_WAIT_LCHAN_ACTIVE] = { .T = 10 },
[ASSIGNMENT_ST_WAIT_RR_ASS_COMPLETE] = { .keep_timer = true },
[ASSIGNMENT_ST_WAIT_LCHAN_ESTABLISHED] = { .keep_timer = true },
[ASSIGNMENT_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = 23042 },
[ASSIGNMENT_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = -9 },
};
/* Transition to a state, using the T timer defined in assignment_fsm_timeouts.

4
src/osmo-bsc/handover_fsm.c
View File

@ -193,8 +193,8 @@ struct gsm_subscriber_connection *ho_fi_conn(struct osmo_fsm_inst *fi)
}
static const struct osmo_tdef_state_timeout ho_fsm_timeouts[32] = {
[HO_ST_WAIT_LCHAN_ACTIVE] = { .T = 23042 },
[HO_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = 23042 },
[HO_ST_WAIT_LCHAN_ACTIVE] = { .T = -29 },
[HO_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = -9 },
[HO_ST_WAIT_RR_HO_DETECT] = { .T = 23042 },
[HO_ST_WAIT_RR_HO_COMPLETE] = { .T = 23042 },
[HO_ST_WAIT_LCHAN_ESTABLISHED] = { .T = 23042 },

1
src/osmo-bsc/net_init.c
View File

@ -73,6 +73,7 @@ static struct osmo_tdef gsm_network_T_defs[] = {
" after this amount of idle time, forget internally cumulated time remainders. Zero to always"
" keep remainders. See also X16, X17." },
{ .T = -25, .default_val = 5, .desc = "Timeout for initial user data after an MSC initiated an SCCP connection to the BSS" },
{ .T = -29, .default_val = 10, .desc = "Timeout for activating an lchan for handover (should be X5 + X6)" },
{ .T = -3111, .default_val = 4, .desc = "Wait time after lchan was released in error (should be T3111 + 2s)" },
{ .T = -3210, .default_val = 20, .desc = "After L3 Complete, wait for MSC to confirm" },
{}