cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 17 

Patch Set 17:

(3 comments)

Patch-set: 17
This commit is contained in:
Gerrit User 1000074 2023-12-05 11:48:33 +00:00 committed by Gerrit Code Review
parent 7cf8e9bb41
commit d07aa01754
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
85b7f5364282fa8a1a2dad13ff4eb6a65779d3c7
View File

@ -140,6 +140,24 @@
"revId": "85b7f5364282fa8a1a2dad13ff4eb6a65779d3c7",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4c9b74ec_01aa9c47",
"filename": "src/osmo-bsc/bsc_vty.c",
"patchSetId": 16
},
"lineNbr": 235,
"author": {
"id": 1000074
},
"writtenOn": "2023-12-05T11:48:33Z",
"side": 1,
"message": "This has been ignored.",
"parentUuid": "d8c3ec12_bf937d5a",
"revId": "85b7f5364282fa8a1a2dad13ff4eb6a65779d3c7",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -192,6 +210,24 @@
"revId": "85b7f5364282fa8a1a2dad13ff4eb6a65779d3c7",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "22fb9289_e4403213",
"filename": "src/osmo-bsc/bsc_vty.c",
"patchSetId": 16
},
"lineNbr": 346,
"author": {
"id": 1000074
},
"writtenOn": "2023-12-05T11:48:33Z",
"side": 1,
"message": "I think for setting timers is totally fine being able to configure them, otherwise config files are going to be failing if someone disables gprs temporarily.\nPlease remove this check, I see no good use for it.",
"parentUuid": "a037ff6a_44fc6994",
"revId": "85b7f5364282fa8a1a2dad13ff4eb6a65779d3c7",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -209,6 +245,24 @@
"revId": "85b7f5364282fa8a1a2dad13ff4eb6a65779d3c7",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "5a8d06ab_2271abb0",
"filename": "src/osmo-bsc/bsc_vty.c",
"patchSetId": 16
},
"lineNbr": 351,
"author": {
"id": 1000074
},
"writtenOn": "2023-12-05T11:48:33Z",
"side": 1,
"message": "this comment was ignored.",
"parentUuid": "07070b25_bd8b2072",
"revId": "85b7f5364282fa8a1a2dad13ff4eb6a65779d3c7",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {