cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

vty: msc / codec-list: tweak error msg 

Change-Id: I7ba508cceccb8a25db0936f756f3e4a28ec1333f
This commit is contained in:
Neels Hofmeyr 2023-03-01 02:32:40 +01:00 committed by neels
parent ec6360e005
commit ce8d39d97c
2 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/osmo-bsc/bsc_vty.c
View File

@ -2752,7 +2752,7 @@ DEFUN_USRATTR(cfg_net_msc_codec_list,
error:
vty_out(vty, "Codec name must be hrX or frX. Was '%s'%s",
argv[i], VTY_NEWLINE);
return CMD_ERR_INCOMPLETE;
return CMD_WARNING;
}
#define LEGACY_STR "This command has no effect, it is kept to support legacy config files\n"

8
tests/msc.vty
View File

@ -34,23 +34,15 @@ msc 0
OsmoBSC(config-msc)# codec-list foo
Codec name must be hrX or frX. Was 'foo'
% Command incomplete.
OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate
OsmoBSC(config-msc)# codec-list fr10
Codec name must be hrX or frX. Was 'fr10'
% Command incomplete.
OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate
OsmoBSC(config-msc)# codec-list hr10
Codec name must be hrX or frX. Was 'hr10'
% Command incomplete.
OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate
OsmoBSC(config-msc)# codec-list FR1
Codec name must be hrX or frX. Was 'FR1'
% Command incomplete.
OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate
OsmoBSC(config-msc)# # Ensure the codec-list with wrong args did not change the config
OsmoBSC(config-msc)# show running-config