cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

vty 'interference-meas level-bounds': explain duality in ordering 

Related: SYS#5313
Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed
This commit is contained in:
Neels Hofmeyr 2021-07-08 06:45:37 +02:00 committed by laforge
parent ae0b737c62
commit 9c61446423
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/osmo-bsc/bsc_vty.c
View File

@ -5051,7 +5051,9 @@ DEFUN_USRATTR(cfg_bts_interf_meas_level_bounds,
"interference-meas level-bounds "
"<-120-0> <-120-0> <-120-0> <-120-0> <-120-0> <-120-0>",
"Interference measurement parameters\n"
"Interference level Boundaries\n"
"Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending"
" order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly"
" some BTS models only return meaningful interference levels with one specific ordering.\n"
"Interference boundary 0 (dBm)\n"
"Interference boundary X1 (dBm)\n"
"Interference boundary X2 (dBm)\n"
@ -5064,7 +5066,6 @@ DEFUN_USRATTR(cfg_bts_interf_meas_level_bounds,
for (i = 0; i < ARRAY_SIZE(bts->interf_meas_params_cfg.bounds_dbm); i++) {
bts->interf_meas_params_cfg.bounds_dbm[i] = abs(atoi(argv[i]));
/* TODO: ensure ascending (or descending?) order */
}
return CMD_SUCCESS;
}

2
tests/interf_meas.vty
View File

@ -12,7 +12,7 @@ OsmoBSC(config-net-bts)# interference-meas?
interference-meas Interference measurement parameters
OsmoBSC(config-net-bts)# interference-meas ?
avg-period Averaging period (Intave)
level-bounds Interference level Boundaries
level-bounds Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly some BTS models only return meaningful interference levels with one specific ordering.
OsmoBSC(config-net-bts)# ### Averaging period
OsmoBSC(config-net-bts)# interference-meas avg-period ?