Update patch set 1

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Harald Welte 2017-10-20 11:21:17 +00:00 committed by Gerrit Code Review
parent daa4be1770
commit 88a252ae34
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "7a8c0949_03ef9cb1",
"filename": "src/osmo-bsc/osmo_bsc_bssap.c",
"patchSetId": 1
},
"lineNbr": 346,
"author": {
"id": 1000004
},
"writtenOn": "2017-10-20T11:21:17Z",
"side": 1,
"message": "I think rather than adding a hand-crafted line with a hand-crafted string of the messag type, you would want to add this ti osmo_bsc_sigtran_send() and parse/dereference the header and use a value_string array to resolve the message type. I prsume we probably have such an array of BSSAP message types alrady somewhere?",
"revId": "3550c9088e6ea1cc6004c8cdd06472bbead97cd8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
}
]
}