cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3: Code-Review-1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1, 65ddbae7174da31007491ec2977c6c93e9f8b8e4
Attention: {"person_ident":"Gerrit User 1000236 \u003c1000236@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010 2023-12-31 21:33:54 +00:00 committed by Gerrit Code Review
parent e00c3d4801
commit 8158116e8b
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
53b1ae36bf97644b1c4b4f6b5fd09be2a1adc280 Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "c3fcd7ac_ea05c0ef",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 1000010
},
"writtenOn": "2023-12-31T21:33:54Z",
"side": 1,
"message": "Please elaborate more why a separate parameter is needed (here in COMMIT_MSG).",
"revId": "53b1ae36bf97644b1c4b4f6b5fd09be2a1adc280",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "5b3e3474_397dda40",
"filename": "src/osmo-bsc/bts_vty.c",
"patchSetId": 3
},
"lineNbr": 777,
"author": {
"id": 1000010
},
"writtenOn": "2023-12-31T21:33:54Z",
"side": 1,
"message": "Let\u0027s combine it into a single command item `expiry-timeout`.",
"range": {
"startLine": 777,
"startChar": 10,
"endLine": 777,
"endChar": 24
},
"revId": "53b1ae36bf97644b1c4b4f6b5fd09be2a1adc280",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "9e726999_a8844337",
"filename": "src/osmo-bsc/bts_vty.c",
"patchSetId": 3
},
"lineNbr": 4532,
"author": {
"id": 1000010
},
"writtenOn": "2023-12-31T21:33:54Z",
"side": 1,
"message": "You\u0027re missing to print `rach expiry-timeout` here.",
"revId": "53b1ae36bf97644b1c4b4f6b5fd09be2a1adc280",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}