cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

fix vty tests: vty no longer goes to parent node implicitly 

Fix three instances of VTY tests working because it used to include implicit
'exit' commands to the parent node.

Since libosmocore change-id Id73cba2dd34676bad8a130e9c45e67a272f19588 = commit
d64b6aed235f6e4d84a2cb8e84b32c3179260254, we no longer do this implicit-exit in
interactive VTY shells.

*) in testPingPongConfiguration, the intention is to enter the /msc 0 node.
   Drop prior entry of the 'network' node, which looks like an oversight. So
   far the 'msc 0' caused an implicit 'exit' and thus worked, now fails.

*) Two instances following comments "# Check searching for outer node's
   commands", which look like they are intended to check for this implicit-exit
   behavior. This is obsolete, drop those parts of the tests.

Change-Id: I77931d6a09c42c443c6936000592f22a7fd06cab
This commit is contained in:
Neels Hofmeyr 2017-09-11 03:32:19 +02:00
parent be356ed32f
commit 75e046b278
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/vty_test_runner.py
View File

@ -139,14 +139,6 @@ class TestVTYBSC(TestVTYGenericBSC):
self.assertTrue(self.vty.verify("exit", ['']))
self.assertTrue(self.vty.node() is None)
# Check searching for outer node's commands
self.vty.command("configure terminal")
self.vty.command('msc 0')
self.vty.command("bsc")
self.assertEquals(self.vty.node(), 'config-bsc')
self.vty.command("msc 0")
self.assertEquals(self.vty.node(), 'config-msc')
def testUssdNotificationsMsc(self):
self.vty.enable()
self.vty.command("configure terminal")
@ -249,7 +241,6 @@ class TestVTYBSC(TestVTYGenericBSC):
def testPingPongConfiguration(self):
self.vty.enable()
self.vty.verify("configure terminal", [''])
self.vty.verify("network", [''])
self.vty.verify("msc 0", [''])
self.vty.verify("timeout-ping 12", [''])
@ -390,19 +381,6 @@ class TestVTYNAT(TestVTYGenericBSC):
self.assertTrue(self.vty.verify('exit', ['']))
self.assertTrue(self.vty.node() is None)
# Check searching for outer node's commands
self.vty.command('configure terminal')
self.vty.command('mgcp')
self.vty.command('nat')
self.assertEquals(self.vty.node(), 'config-nat')
self.vty.command('mgcp')
self.assertEquals(self.vty.node(), 'config-mgcp')
self.vty.command('nat')
self.assertEquals(self.vty.node(), 'config-nat')
self.vty.command('bsc 0')
self.vty.command('mgcp')
self.assertEquals(self.vty.node(), 'config-mgcp')
def testRewriteNoRewrite(self):
self.vty.enable()
res = self.vty.command("configure terminal")