Update patch set 7

Patch Set 7:

(5 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 1000229 \u003c1000229@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}

7bbfa1399b2d29a9a5e28fe70d14f3d59b78dd57

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e1361416_f0442e57",
+        "filename": "include/osmocom/bsc/bts.h",
+        "patchSetId": 7
+      },
+      "lineNbr": 347,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:03:34Z",
+      "side": 0,
+      "message": "why is this being removed here? it probably should be removed in the previous commit?",
+      "revId": "7bbfa1399b2d29a9a5e28fe70d14f3d59b78dd57",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}

92563cec83599720fcd4ad6cc04fbf4ea3964975

@@ -0,0 +1,72 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "73d560f5_01f82f49",
+        "filename": "src/osmo-bsc/bts_init.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 111,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:03:34Z",
+      "side": 1,
+      "message": "it will probably help adding an extra blank line before this one.",
+      "revId": "92563cec83599720fcd4ad6cc04fbf4ea3964975",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "49d596a6_1cb99518",
+        "filename": "src/osmo-bsc/bts_vty.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 1662,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:03:34Z",
+      "side": 1,
+      "message": "I\u0027m still totally not understanding why do you need this index lookup here. If you want to keep the older indices to keep backward compatibilities, why not using those same timer names in the tdef structure?",
+      "revId": "92563cec83599720fcd4ad6cc04fbf4ea3964975",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "3ada7b05_d99d0ee3",
+        "filename": "src/osmo-bsc/pcu_sock.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 225,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:03:34Z",
+      "side": 1,
+      "message": "you could fix your proper commit and already use this name so you don\u0027t need to change it in the followup commit (and save my time reviewing it).",
+      "revId": "92563cec83599720fcd4ad6cc04fbf4ea3964975",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f5b24ba8_fc25acc3",
+        "filename": "tests/gprs_params.vty",
+        "patchSetId": 7
+      },
+      "lineNbr": 36,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:03:34Z",
+      "side": 1,
+      "message": "why did the timers dissappear here? because they are the default values? then ACK.",
+      "revId": "92563cec83599720fcd4ad6cc04fbf4ea3964975",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}