cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

assignment: remove unnecessary call to gsm0808_speech_codec_from_chan_type() 

There is a function call to gsm0808_speech_codec_from_chan_type() after
an if construct that checks if we need voice and if we need it if it is
related to an AoIP connection.

However, at the moment we call gsm0808_speech_codec_from_chan_type() all
the time, even when just figured out that we don't need to. Presumably
this is a refactory leftover. Lets remove the excess function call.

Change-Id: I34d9281944b36cd89ad8e1c5774f0ea80fdfadc8
This commit is contained in:
Philipp Maier 2018-09-05 14:49:12 +02:00 committed by Neels Hofmeyr
parent 9134d330f6
commit 5aac651cee
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/osmo-bsc/assignment_fsm.c
View File

@ -171,8 +171,6 @@ static void send_assignment_complete(struct gsm_subscriber_connection *conn, str
/* FIXME: AMR codec configuration must be derived from lchan1! */
}
gsm0808_speech_codec_from_chan_type(&sc, perm_spch);
resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,
chosen_channel,
lchan->encr.alg_id, perm_spch,