Update patch set 1
Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
This commit is contained in:
parent
57b880cecd
commit
5a17d61dab
|
@ -16,6 +16,24 @@
|
|||
"message": "maybe add log messages instead of having the commented out code?",
|
||||
"revId": "2efe46a3c333a08dccba88bf6c2b5fc766cab393",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "37a19e47_6b045711",
|
||||
"filename": "src/osmo-bsc/cbsp_link.c",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 166,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2024-04-18T09:54:24Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027m basically leaving the code which was there before and got removed when moving to osmo_io, but simply commenting it out since it really is a no-op. Still I think it\u0027s useful keeping it in case someone wants to do more fine-grained error handling.\n\n85687bf176e4b9663f2396a27c28b49221c72fa3:\n\n - /* READ */\n - rc \u003d osmo_cbsp_recv_buffered(cbc, ofd-\u003efd, \u0026msg, \u0026cbc-\u003eclient.msg);\n - if (rc \u003c\u003d 0) {\n - if (rc \u003d\u003d -EAGAIN || rc \u003d\u003d -EINTR) {\n - /* more data needs to be read */\n - return 0;\n - } else if (rc \u003d\u003d -EPIPE || rc \u003d\u003d -ECONNRESET) {\n - /* lost connection */\n - } else if (rc \u003d\u003d 0) {\n - /* connection closed */\n - }\n - osmo_stream_cli_reconnect(cli);\n - return -EBADF;\n - }",
|
||||
"parentUuid": "315e878b_2f3b2037",
|
||||
"revId": "2efe46a3c333a08dccba88bf6c2b5fc766cab393",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue