cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 7 

Patch Set 7:

(4 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 1000229 \u003c1000229@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000229\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000229\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000229 2023-12-05 08:57:17 +00:00 committed by Gerrit Code Review
parent 35e1430da9
commit 4f3d89287d
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
c1809556f0cf8ed2c463cf94146496b93ffad4f9
View File

@ -34,6 +34,24 @@
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "79739441_23ab5969",
"filename": "include/osmocom/bsc/bts.h",
"patchSetId": 2
},
"lineNbr": 326,
"author": {
"id": 1000229
},
"writtenOn": "2023-12-05T08:57:17Z",
"side": 1,
"message": "Done",
"parentUuid": "81c13d98_bee9d723",
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "39ebfef1_022fa19a",
"filename": "src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c",
"patchSetId": 2
},
"lineNbr": 187,
"author": {
"id": 1000229
},
"writtenOn": "2023-12-05T08:57:17Z",
"side": 1,
"message": "Done",
"parentUuid": "cb9190bc_b2e5811e",
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -68,6 +104,24 @@
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "2a683e66_6e7a8c89",
"filename": "src/osmo-bsc/bts_vty.c",
"patchSetId": 2
},
"lineNbr": 76,
"author": {
"id": 1000229
},
"writtenOn": "2023-12-05T08:57:17Z",
"side": 1,
"message": "I originally put it below `gprs_ns_timer_strs` so that the index correspondence can be checked easily. I\u0027ve moved it now.",
"parentUuid": "bf555dbd_2e2108c9",
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -84,6 +138,24 @@
"message": "so you are converting to an index here once, and in line 1637 again. This looks ptoentially wrong. Why isn\u0027t this get_string_value providing the interesting idx directly?",
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "5f9337fe_17162c2b",
"filename": "src/osmo-bsc/bts_vty.c",
"patchSetId": 2
},
"lineNbr": 1627,
"author": {
"id": 1000229
},
"writtenOn": "2023-12-05T08:57:17Z",
"side": 1,
"message": "Not sure what you mean to say. I\u0027m only converting a string to an index once. That same index is then used to get the corresponding data for setting the tdef for the BTS.",
"parentUuid": "63253556_aa03e90e",
"revId": "c1809556f0cf8ed2c463cf94146496b93ffad4f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}