Update patch set 2

Patch Set 2: Code-Review+2 (2 comments) Patch-set: 2 Label: Code-Review=+2
2017-09-05 21:20:43 +00:00 · 2017-09-05 21:20:43 +00:00 · 4914acbb31
parent 5b434c2fb9
commit 4914acbb31
1 changed files with 38 additions and 0 deletions
--- a/38
+++ b/38
@ -0,0 +1,38 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9aa7fdbe_f8ffa5a8",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 12,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2017-09-05T21:20:43Z",
+      "side": 1,
+      "message": "\"and log only when the state has changed\"",
+      "revId": "b6b339523c1295c4e68344d84c7728ae811c0c07",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9aa7fdbe_3863edb2",
+        "filename": "include/openbsc/abis_rsl.h",
+        "patchSetId": 2
+      },
+      "lineNbr": 37,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2017-09-05T21:20:43Z",
+      "side": 1,
+      "message": "(would even have been acceptable to name the macro exactly like the function was named, making the patch smaller. We did something like that for osmo_fsm_*, for example.)",
+      "revId": "b6b339523c1295c4e68344d84c7728ae811c0c07",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": false
+    }
+  ]
+}