Update patch set 8

Patch Set 8:

(5 comments)

Patch-set: 8
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}

92563cec83599720fcd4ad6cc04fbf4ea3964975

@@ -0,0 +1,38 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c7ac3904_99c10ccd",
+        "filename": "include/osmocom/bsc/vty.h",
+        "patchSetId": 8
+      },
+      "lineNbr": 106,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:10:21Z",
+      "side": 0,
+      "message": "IMHOyou should in general avoid filling your commits in a patchset with this type of comments which only make them more complex to review. This kind of stuff is for you keep private during dev imho.",
+      "revId": "92563cec83599720fcd4ad6cc04fbf4ea3964975",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "59055467_74eb3aaf",
+        "filename": "src/osmo-bsc/bsc_vty.c",
+        "patchSetId": 8
+      },
+      "lineNbr": 323,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:10:21Z",
+      "side": 0,
+      "message": "Same with this one.",
+      "revId": "92563cec83599720fcd4ad6cc04fbf4ea3964975",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}

dccda593e6810fa20cf293109bb0ec90e82905ce

@@ -0,0 +1,55 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "6814fd72_fbcff715",
+        "filename": "src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c",
+        "patchSetId": 8
+      },
+      "lineNbr": 212,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:10:21Z",
+      "side": 1,
+      "message": "so you added defines for timers 1..4 but you are not using them?",
+      "revId": "dccda593e6810fa20cf293109bb0ec90e82905ce",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "00deb420_fbbce117",
+        "filename": "src/osmo-bsc/bts_vty.c",
+        "patchSetId": 8
+      },
+      "lineNbr": 1704,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:10:21Z",
+      "side": 1,
+      "message": "I still find this is most probably not needed.\n\nYou can probably change the indices in gprs_bssgp_cfg_strs to directly be the GSM_BTS_TDEF_ID_BSSGP_* values?",
+      "revId": "dccda593e6810fa20cf293109bb0ec90e82905ce",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "6f2ae417_4db4b14d",
+        "filename": "src/osmo-bsc/bts_vty.c",
+        "patchSetId": 8
+      },
+      "lineNbr": 1741,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-12-05T12:10:21Z",
+      "side": 1,
+      "message": "definetly not in a single line.",
+      "revId": "dccda593e6810fa20cf293109bb0ec90e82905ce",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}