cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

bsc_msc_data: remove unused member is_authenticated 

The struct member struct bsc_msc_data->is_authenticated is set to true
permanently. This is a leftover from the sccplite implementation and can
be removed now.

Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9
Related: OS#3112
This commit is contained in:
Philipp Maier 2019-07-31 13:15:37 +02:00 committed by laforge
parent 3c9485751c
commit 3bc9b16459
3 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/osmocom/bsc/bsc_msc_data.h
View File

@ -77,7 +77,6 @@ struct bsc_msc_data {
int core_lac;
int core_ci;
int rtp_base;
bool is_authenticated;
/* audio codecs */
struct gsm48_multi_rate_conf amr_conf;

2
src/osmo-bsc/gsm_08_08.c
View File

@ -307,8 +307,6 @@ struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection *conn,
round_robin:
llist_for_each_entry(msc, &bsc->mscs, entry) {
if (!msc->is_authenticated)
continue;
if (!is_emerg && msc->type != MSC_CON_TYPE_NORMAL)
continue;
if (is_emerg && !msc->allow_emerg)

7
src/osmo-bsc/osmo_bsc_msc.c
View File

@ -49,13 +49,6 @@ int osmo_bsc_msc_init(struct bsc_msc_data *msc)
uint16_t mgw_port;
int rc;
/* FIXME: This is a leftover from the old architecture that used
* sccp-lite with osmocom specific authentication. Since we now
* changed to AoIP the connected status and the authentication
* status is managed differently. However osmo_bsc_filter.c still
* needs the flags to be set to one. See also: OS#3112 */
msc->is_authenticated = 1;
if (net->mgw.conf->remote_port >= 0)
mgw_port = net->mgw.conf->remote_port;
else