Update patch set 1

Patch Set 1:

(2 comments)

Patch-set: 1
CC: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
Gerrit User 1000010 2024-01-15 18:27:47 +00:00 committed by Gerrit Code Review
parent 965d26e990
commit 3952c2b047
1 changed files with 50 additions and 0 deletions

View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "893773ba_ff87bb28",
"filename": "src/osmo-bsc/bsc_vty.c",
"patchSetId": 1
},
"lineNbr": 262,
"author": {
"id": 1000010
},
"writtenOn": "2024-01-15T18:27:47Z",
"side": 1,
"message": "`online` in the command name suggests that the command is supposed to show only those BTS instances, which are online. However, it\u0027s actually more like `brief`.",
"range": {
"startLine": 262,
"startChar": 3,
"endLine": 262,
"endChar": 41
},
"revId": "f0ea7a21093197d45ddd093866e42ddfd60ff777",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "3c2438f5_47eee87a",
"filename": "src/osmo-bsc/bsc_vty.c",
"patchSetId": 1
},
"lineNbr": 268,
"author": {
"id": 1000010
},
"writtenOn": "2024-01-15T18:27:47Z",
"side": 1,
"message": "Not a performance critical path, but I would still suggest doing this:\n\n```\nllist_for_each_entry(bts, \u0026net-\u003ebts_list, list)\n```\n\ninstead. This is what `gsm_bts_num()` does internally. The problem with the current approach is that the higher `bts_nr` you pass it, the more iterations it takes to find the BTS instance.",
"range": {
"startLine": 268,
"startChar": 1,
"endLine": 268,
"endChar": 50
},
"revId": "f0ea7a21093197d45ddd093866e42ddfd60ff777",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}