Update patch set 1

Patch Set 1: Code-Review+1

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 42550a20c8810eb8926556f390985058398e48c3
This commit is contained in:
Gerrit User 1000010 2024-01-15 18:18:19 +00:00 committed by Gerrit Code Review
parent 89d548376f
commit 2ad496f935
2 changed files with 50 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "4637eff3_ae293e19",
"filename": "src/osmo-bsc/bts.c",
"patchSetId": 1
},
"lineNbr": 831,
"author": {
"id": 1000010
},
"writtenOn": "2024-01-15T18:18:19Z",
"side": 0,
"message": "A note for other reviewers: this is the key change of this patch.",
"range": {
"startLine": 831,
"startChar": 21,
"endLine": 831,
"endChar": 35
},
"revId": "1cfec9d2c98593f813d77246494f5396201ec88e",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

View File

@ -1,5 +1,28 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e1fd827b_a6a45626",
"filename": "src/osmo-bsc/bts_ctrl.c",
"patchSetId": 1
},
"lineNbr": 375,
"author": {
"id": 1000010
},
"writtenOn": "2024-01-15T18:18:19Z",
"side": 1,
"message": "The command is called `oml-uptime`.\nMaybe emulate the old behavior here (like you do in `bts_store_uptime()`)?",
"range": {
"startLine": 375,
"startChar": 43,
"endLine": 375,
"endChar": 57
},
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {