cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

silence bogus error: event not permitted: READY_TO_SWITCH_RTP 

During inter-BSC incoming handover, there is no previous lchan to be
switched, so this event always comes in the READY state of
lchan_rtp_fsm. No need to complain about that and confuse log readers.

Related: SYS#5864
Change-Id: I96fd53b8c8da621a40bd65f85070eabd030cc875
This commit is contained in:
Neels Hofmeyr 2022-03-03 02:25:08 +01:00 committed by neels
parent e761affc6a
commit 1f089842a8
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/osmo-bsc/lchan_rtp_fsm.c
View File

@ -522,6 +522,12 @@ static void lchan_rtp_fsm_ready(struct osmo_fsm_inst *fi, uint32_t event, void *
lchan_rtp_fsm_state_chg(LCHAN_RTP_ST_ROLLBACK);
return;
case LCHAN_RTP_EV_READY_TO_SWITCH_RTP:
/* Ignore / silence an "event not permitted" error. In case of an inter-BSC incoming handover, there is
* no previous lchan to be switched over, and we are already in this state when the usual handover code
* path emits this event. */
return;
default:
OSMO_ASSERT(false);
}
@ -704,6 +710,7 @@ static const struct osmo_fsm_state lchan_rtp_fsm_states[] = {
| S(LCHAN_RTP_EV_ESTABLISHED)
| S(LCHAN_RTP_EV_RELEASE)
| S(LCHAN_RTP_EV_ROLLBACK)
| S(LCHAN_RTP_EV_READY_TO_SWITCH_RTP)
,
.out_state_mask = 0
| S(LCHAN_RTP_ST_ESTABLISHED)