cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

fix use after free in bsc_config_free 

talloc_free the cfg only after asserting num_bsc count sanity.
This caused a failure in the 'bsc-nat' test with -fsanitize build.

Should fix the Osmocom_Sanitizer build on jenkins.osmocom.org
https://jenkins.osmocom.org/jenkins/job/Osmocom_Sanitizer/

Change-Id: Ic20aacaccffcaa58ccec6d24c884727dc1bc50e6
This commit is contained in:
Neels Hofmeyr 2016-11-10 03:19:21 +01:00
parent b4ecc1d43b
commit 194b4cb4fd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openbsc/src/osmo-bsc_nat/bsc_nat_utils.c
View File

@ -205,9 +205,9 @@ void bsc_config_free(struct bsc_config *cfg)
{
llist_del(&cfg->entry);
rate_ctr_group_free(cfg->stats.ctrg);
talloc_free(cfg);
cfg->nat->num_bsc--;
OSMO_ASSERT(cfg->nat->num_bsc >= 0)
talloc_free(cfg);
}
static void _add_lac(void *ctx, struct llist_head *list, int _lac)