cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

fix assignment success counters: count *before* cleanup of fsm state 

Counting the Assignment success after osmo_fsm_inst_term() meant that we
were counting a cleared out channel mode, which always yielded
signalling mode.

Count the Assignment success *before* terminating, so that we correctly
count the successful assignment as speech mode.

Related: SYS#4878
Related: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 (osmo-ttcn3-hacks)
Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8
This commit is contained in:
Neels Hofmeyr 2021-11-29 16:25:34 +01:00 committed by Pau Espin Pedrol
parent 249bff0b02
commit 0fdb143516
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/osmo-bsc/assignment_fsm.c
View File

@ -287,10 +287,10 @@ static void assignment_success(struct gsm_subscriber_connection *conn)
conn->user_plane.msc_assigned_rtp_port = conn->assignment.req.msc_rtp_port;
}
assignment_count_result(CTR_ASSIGNMENT_COMPLETED);
LOG_ASSIGNMENT(conn, LOGL_DEBUG, "Assignment successful\n");
osmo_fsm_inst_term(conn->assignment.fi, OSMO_FSM_TERM_REGULAR, 0);
assignment_count_result(CTR_ASSIGNMENT_COMPLETED);
}
static void assignment_fsm_update_id(struct gsm_subscriber_connection *conn)