Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000231 \u003c1000231@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000231\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000231\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000231 2024-01-15 11:09:05 +00:00 committed by Gerrit Code Review
parent 94880ab931
commit 0c31f7bf90
1 changed files with 18 additions and 0 deletions

View File

@ -16,6 +16,24 @@
"message": "Looks like you probably want to add the downtime count here instead of ipaccess_drop_oml()? What if the links goes down due to some other path different than ipaccess_drop_oml()?",
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "2bb98965_0121496b",
"filename": "src/osmo-bsc/bts_ipaccess_nanobts.c",
"patchSetId": 1
},
"lineNbr": 763,
"author": {
"id": 1000231
},
"writtenOn": "2024-01-15T11:09:05Z",
"side": 1,
"message": "ipaccess_sign_link_down() calls ipaccess_drop_oml() in any case.\nipaccess_sign_link_down() acquires the BTS pointer from the link that went down.",
"parentUuid": "d8b99b78_3195d22d",
"revId": "76f2266317c0df8fd51a44af3dfa996924f5e751",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}