cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity
osmo-bsc/src/osmo-bsc/paging.c

512 lines
15 KiB
C
Raw Normal View History

Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
/* Paging helper and manager.... */
bsc: Allow to page a BTS that is excluded from the RF lock The RF lock excluded BTS was not paged at all. Now forward the paging message to the handler and call a function that will check if this LAC can be paged right now. Introduce a new paging method that allows to page on a dedicated bts, refactor the code to use this method for paging.
2013-01-07 16:30:13 +00:00
/* (C) 2009,2013 by Holger Hans Peter Freyther <zecke@selfish.org>
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
* All Rights Reserved
*
* This program is free software; you can redistribute it and/or modify
License change: We are now AGPLv3+ instead of GPLv2+ The reason for this is quite simple: We want to make sure anyone running a customized version of OpenBSC to operate a network will have to release all custom modifiations to the source code.
2011-01-01 14:25:50 +00:00
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
License change: We are now AGPLv3+ instead of GPLv2+ The reason for this is quite simple: We want to make sure anyone running a customized version of OpenBSC to operate a network will have to release all custom modifiations to the source code.
2011-01-01 14:25:50 +00:00
* GNU Affero General Public License for more details.
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
*
License change: We are now AGPLv3+ instead of GPLv2+ The reason for this is quite simple: We want to make sure anyone running a customized version of OpenBSC to operate a network will have to release all custom modifiations to the source code.
2011-01-01 14:25:50 +00:00
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
*
*/
/*
* Relevant specs:
* 12.21:
* - 9.4.12 for CCCH Local Threshold
*
* 05.58:
* - 8.5.2 CCCH Load indication
* - 9.3.15 Paging Load
*
* Approach:
* - Send paging command to subscriber
* - On Channel Request we will remember the reason
* - After the ACK we will request the identity
* - Then we will send assign the gsm_subscriber and
* - and call a callback
*/
[paging] Page pagegroup one... Currently we get OVERLOAD (8.6.3 of 08.58) and no CCCH LOAD INDICATION... we will have to handle the OVERLOAD somehow...
2009-01-06 23:50:39 +00:00
#include <stdio.h>
#include <stdlib.h>
[paging] Send up to avaliable_slots paging requests... Send up to available_slots paging requests but only iterate over the list once. This was not tested on a bts.
2009-02-14 18:05:03 +00:00
#include <assert.h>
[paging] Page pagegroup one... Currently we get OVERLOAD (8.6.3 of 08.58) and no CCCH LOAD INDICATION... we will have to handle the OVERLOAD somehow...
2009-01-06 23:50:39 +00:00
src: use new library libosmogsm and new path to headers in libosmocore libosmogsm is a new library that is distributed in the libosmocore. Now, openbsc depends on it. This patch gets openbsc with this change. This patch also rewrites all include path to the new osmocom/[gsm|core] Signed-off-by: Pablo Neira Ayuso <pablo@gnumonks.org>
2011-03-22 15:47:59 +00:00
#include <osmocom/core/talloc.h>
use libosmocore osmo_tdef Move the T_defs API to libosmocore as osmo_tdefs: remove the local T_defs API and use libosmocore's osmo_tdef* API instead. The root reason is moving the mgw_endpoint_fsm to libosmo-mgcp-client to be able to use it in osmo-msc for inter-MSC handover. When adding osmo_tdef, the new concept of timer groups was added to the API. It would make sense to apply group names here as well, but do not modify the VTY configuration for timers. The future might bring separate groups (or not). Depends: Ibd6b1ed7f1bd6e1f2e0fde53352055a4468f23e5 (libosmocore) Change-Id: I66674a5d8403d820038762888c846bae10ceac58
2019-01-28 02:52:14 +00:00
#include <osmocom/core/tdef.h>
use new gsm48_number_of_paging_subchannels from libosmocore
2011-06-26 12:21:43 +00:00
#include <osmocom/gsm/gsm48.h>
move gsm 05.02 related calculations into libosmocore
2011-06-26 12:41:58 +00:00
#include <osmocom/gsm/gsm0502.h>
use new gsm48_number_of_paging_subchannels from libosmocore
2011-06-26 12:21:43 +00:00
move include/openbsc to include/osmocom/bsc Change-Id: I39e7b882caa98334636d19ccd104fd83d07d5055
2017-09-04 13:15:32 +00:00
#include <osmocom/bsc/bsc_subscriber.h>
#include <osmocom/bsc/paging.h>
#include <osmocom/bsc/debug.h>
#include <osmocom/bsc/signal.h>
#include <osmocom/bsc/abis_rsl.h>
#include <osmocom/bsc/gsm_data.h>
#include <osmocom/bsc/chan_alloc.h>
cosmetic: rename bsc_api.h to gsm_08_08.h See also I91922f557072d0fb8cfe213a8a7b50f3bb23dea0, which renames osmo_bsc_api.c to gsm_08_08.c. Change-Id: I7179eb27183ee213f8fc8d548895b67aa43dc6a2
2018-07-24 16:10:05 +00:00
#include <osmocom/bsc/gsm_08_08.h>
rename gsm_04_08_utils.[hc] to gsm_04_08_rr "utils" suggests thin helpers to aid using a proper API, while this .c file actually *is* the proper RR API. Rename from "utils" to "rr". Change-Id: I0ffff63d57f03cb324df8e40e41caea5b55a2c85
2018-07-24 14:18:15 +00:00
#include <osmocom/bsc/gsm_04_08_rr.h>
large refactoring: use FSMs for lchans; add inter-BSC HO Add FSMs: - timeslot_fsm: handle dynamic timeslots and OML+RSL availability. - lchan_fsm: handle an individual lchan activation, RTP stream and release, signal the appropriate calling FSMs on success, failure, release. - mgw_endpoint_fsm: handle one entire endpoint with several CI. - assignment_fsm: BSSMAP Assignment Request. - handover_fsm: all of intra, inter-MO and inter-MT handover. Above FSMs absorb large parts of the gscon FSM. The gscon FSM was surpassing the maximum amount events (32), and it is more logical to treat assignment, handover and MGW procedures in separate FSMs. - Add logging macros for each FSM type: - LOG_TS() - LOG_LCHAN() - LOG_MGWEP(), LOG_CI() - LOG_ASSIGNMENT() - LOG_HO() These log with the osmo_fsm_inst where present. New style decision: logging without a final newline char is awkward, especially for gsmtap logging and when other logs interleave LOGPC() calls; we have various cases where the final \n goes missing, and also this invokes the log category checking N times instead of once. So I decided to make these macros *always* append a newline, but only if there is no final newline yet. I hope that the compiler optimizes the strlen() of the constant format strings away. Thus I can log with or without typing "\n" and always get an \n termination anyway. General: - replace osmo_timers, state enums and program-wide osmo_signal_dispatch() with dedicated FSM timeouts, states and events. - introduce a common way to handle Tnnn timers: gsm_timers.h/.c: struct T_def. These can be used (with some macro magic) to define a state's timeout once, and not make mistakes for each osmo_fsm_inst_state_chg(). Details: bsc_subscr_conn_fsm.c: - move most states of this FSM to lchan_fsm, assignment_fsm, handover_fsm and mgw_endpoint_fsm. - There is exactly one state for an ongoing Assignment, with all details handled in conn->assignment.fi. The state relies on the assignment_fsm's timeout. - There is one state for an ongoing Handover; except for an incoming Handover from a remote BSS, the gscon remains in ST_INIT until the new lchan and conn are both established. - move bssmap_add_lcls_status() to osmo_bsc_lcls.c abis_rsl.c: - move all dynamic timeslot logic away into timeslot_fsm. Only keep plain send/receive functions in abis_rsl.c - reduce some rsl functions to merely send a message, rename to "_tx_". - rsl_ipacc_mdcx(): add '_tx_' in the name; move parts that change the lchan state out into the lchan_fsm, the lchan->abis_ip.* are now set there prior to invoking this function. - move all timers and error/release handling away into various FSMs. - tweak ipa_smod_s_for_lchan() and ipa_rtp_pt_for_lchan() to not require an lchan passed, but just mode,type that they require. Rename to ipacc_speech_mode*() and ipacc_payload_type(). - add rsl_forward_layer3_info, used for inter-BSC HO MO, to just send the RR message received during BSSMAP Handover Command. - move various logging to LOG_LCHAN() in order to log with the lchan FSM instance. One drawback is that the lchan FSM is limited to one logging category, i.e. this moves some logging from DRR to DRSL. It might actually make sense to combine those categories. - lose LOGP...LOGPC logging cascades: they are bad for gsmtap logging and for performance. - handle_classmark_chg(): change logging, move cm2 len check out of the cm3 condition (I hope that's correct). - gsm48_send_ho_cmd(): split off gsm48_make_ho_cmd() which doesn't send right away, so that during inter-bsc HO we can make an RR Handover Command to send via the MSC to the remote BSS. assignment_fsm.c: - the Chan Mode Modify in case of re-using the same lchan is not implemented yet, because this was also missing in the previous implementation (OS#3357). osmo_bsc_api.c: - simplify bsc_mr_config() and move to lchan_fsm.c, the only caller; rename to lchan_mr_config(). (bsc_mr_config() used to copy the values to mr_bts_lv twice, once by member assignment and then again with a memcpy.) - During handover, we used to copy the MR config from the old lchan. Since we may handover between FR and HR, rather set the MR Config anew every time, so that FR rates are always available on FR lchans, and never on HR lchans. Depends: I03ee7ce840ecfa0b6a33358e7385528aabd4873f (libosmocore), I1f2918418c38918c5ac70acaa51a47adfca12b5e (libosmocore) Change-Id: I82e3f918295daa83274a4cf803f046979f284366
2018-05-14 16:14:15 +00:00
#include <osmocom/bsc/bsc_subscr_conn_fsm.h>
Move struct gsm_bts: gsm_data.* => bts.* Place all code related to the object into the related file. Having all the data model in one file made sense in early stage of development to make progress quickly, but nowadays it hurts more than helps, due to constantly growing size and more and more bits being added to the model, gaining in complexity. Currently, having lots of different objects mixed up in gsm_data.h is a hole of despair, where nobody can make any sense were to properly put new stuff in, ending up with functions related to same object in different files or with wrong prefixes, declarations of non-existing functions, etc. because people cannot make up their mind on strict relation to objects in the data model. Splitting them in files really helps finding code operating on a specific object and helping with logically splitting in the future. Change-Id: I00c15f5285b5c1a0109279b7ab192d5467a04ece
2020-07-15 18:53:16 +00:00
#include <osmocom/bsc/bts.h>
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
libcommon: eliminate talloc_ctx.c Interestingly enough, talloc_ctx_init() actually had not a single caller. While dropping it, see to it that the few contexts that are actually used in osmo-bsc.git are indeed initialized in all the main scopes. Also initialize two void* ctxts as NULL explicitly, to allocate under the NULL context in case some main scope forgets to branch it off another root context. (That's bsc, fle and paging, all others actually come in from other libraries.) Change-Id: I344a3d07e146999e154824837ed95db2b9879356
2018-02-13 20:21:42 +00:00
void *tall_paging_ctx = NULL;
introduce talloc all over OpenBSC
2009-06-20 20:36:41 +00:00
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
#define PAGING_TIMER 0, 500000
Hook the paging code into bsc_hack.c and telnet_interface.c Wrote and test code to add and remove paging requests... This will be using the fact that the linux list is building a circle on each tick we can send one/x paging requests and continue round robin...
2009-01-06 23:10:57 +00:00
/*
* Kill one paging request update the internal list...
*/
[paging] Cleanup page -> paging in function names
2009-02-09 23:42:03 +00:00
static void paging_remove_request(struct gsm_bts_paging_state *paging_bts,
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
struct gsm_paging_request *to_be_deleted)
[paging] Use paging_request_remove to update last_request and free memory Update the last_request when stopping the paging operation and also free the associated memory of the request.
2009-02-06 18:08:18 +00:00
{
src: use namespace prefix osmo_timer* for timer functions Summary of changes: s/struct timer_list/struct osmo_timer_list/g s/bsc_add_timer/osmo_timer_add/g s/bsc_schedule_timer/osmo_timer_schedule/g s/bsc_del_timer/osmo_timer_del/g s/bsc_timer_pending/osmo_timer_pending/g s/bsc_nearest_timer/osmo_timers_nearest/g s/bsc_prepare_timers/osmo_timers_prepare/g s/bsc_update_timers/osmo_timers_update/g s/bsc_timer_check/osmo_timers_check/g
2011-05-06 10:11:06 +00:00
osmo_timer_del(&to_be_deleted->T3113);
Hook the paging code into bsc_hack.c and telnet_interface.c Wrote and test code to add and remove paging requests... This will be using the fact that the linux list is building a circle on each tick we can send one/x paging requests and continue round robin...
2009-01-06 23:10:57 +00:00
llist_del(&to_be_deleted->entry);
introduce osmo_use_count for bsc_subscr During LCS development, I'm getting use count bugs and would like to see use token strings to figure it out. Change-Id: I29bf60059d4cf7bb99a00753e6cdc149baf95f94
2020-09-15 01:03:58 +00:00
bsc_subscr_put(to_be_deleted->bsub, BSUB_USE_PAGING_REQUEST);
introduce talloc all over OpenBSC
2009-06-20 20:36:41 +00:00
talloc_free(to_be_deleted);
Hook the paging code into bsc_hack.c and telnet_interface.c Wrote and test code to add and remove paging requests... This will be using the fact that the linux list is building a circle on each tick we can send one/x paging requests and continue round robin...
2009-01-06 23:10:57 +00:00
}
[paging] Move the code to send the command into a separate function Mostly cosmetic and in preparation for proper page load indicator handling.
2009-02-06 22:33:25 +00:00
static void page_ms(struct gsm_paging_request *request)
{
unsigned int page_group;
generalize function for calculation of the paging group
2011-06-26 12:43:46 +00:00
struct gsm_bts *bts = request->bts;
use osmo_mobile_identity API everywhere Depends: If4f7be606e54cfa1c59084cf169785b1cbda5cf5 (libosmocore) Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a
2020-05-29 01:53:59 +00:00
struct osmo_mobile_identity mi;
[paging] Move the code to send the command into a separate function Mostly cosmetic and in preparation for proper page load indicator handling.
2009-02-06 22:33:25 +00:00
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
log_set_context(LOG_CTX_BSC_SUBSCR, request->bsub);
logging: Set the context for paging requests as well.
2014-12-28 14:00:36 +00:00
logging: introduce LOG_BTS and LOG_TRX and use it everywhere It's quite ugly to have manual "bts=%d" printf-statements all over the BSC code. Let's change this to use shared logging helper functions all over the place, whenever we need to log something related to one BTS or one TRX. This can also help us as the first step to later add alternative logging of BTS identities, e.g. by printing the Cell Global Identifier or LAC+CI, or even a human-readable/vty-defined 'name' of the BTS, rather than its numeric bts number. With this change in place, we can introduce such changes at a single location in the code. Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c
2019-06-13 14:37:24 +00:00
LOG_BTS(bts, DPAG, LOGL_INFO, "Going to send paging commands: imsi: %s tmsi: "
"0x%08x for ch. type %d (attempt %d)\n", request->bsub->imsi,
request->bsub->tmsi, request->chan_type, request->attempts);
[paging] Implement paging by IMSI. Try to page by IMSI when the TMSI is not set. This will be required to properly support the MSC/BSSMAP.
2009-08-21 12:55:57 +00:00
use osmo_mobile_identity API everywhere Depends: If4f7be606e54cfa1c59084cf169785b1cbda5cf5 (libosmocore) Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a
2020-05-29 01:53:59 +00:00
if (request->bsub->tmsi == GSM_RESERVED_TMSI) {
mi = (struct osmo_mobile_identity){
.type = GSM_MI_TYPE_IMSI,
};
OSMO_STRLCPY_ARRAY(mi.imsi, request->bsub->imsi);
} else {
mi = (struct osmo_mobile_identity){
.type = GSM_MI_TYPE_TMSI,
.tmsi = request->bsub->tmsi,
};
}
[paging] Move the code to send the command into a separate function Mostly cosmetic and in preparation for proper page load indicator handling.
2009-02-06 22:33:25 +00:00
generalize function for calculation of the paging group
2011-06-26 12:43:46 +00:00
page_group = gsm0502_calc_paging_group(&bts->si_common.chan_desc,
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
str_to_imsi(request->bsub->imsi));
use osmo_mobile_identity API everywhere Depends: If4f7be606e54cfa1c59084cf169785b1cbda5cf5 (libosmocore) Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a
2020-05-29 01:53:59 +00:00
rsl_paging_cmd(bts, page_group, &mi, request->chan_type, false);
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
log_set_context(LOG_CTX_BSC_SUBSCR, NULL);
[paging] Move the code to send the command into a separate function Mostly cosmetic and in preparation for proper page load indicator handling.
2009-02-06 22:33:25 +00:00
}
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
static void paging_schedule_if_needed(struct gsm_bts_paging_state *paging_bts)
{
if (llist_empty(&paging_bts->pending_requests))
return;
src: use namespace prefix osmo_timer* for timer functions Summary of changes: s/struct timer_list/struct osmo_timer_list/g s/bsc_add_timer/osmo_timer_add/g s/bsc_schedule_timer/osmo_timer_schedule/g s/bsc_del_timer/osmo_timer_del/g s/bsc_timer_pending/osmo_timer_pending/g s/bsc_nearest_timer/osmo_timers_nearest/g s/bsc_prepare_timers/osmo_timers_prepare/g s/bsc_update_timers/osmo_timers_update/g s/bsc_timer_check/osmo_timers_check/g
2011-05-06 10:11:06 +00:00
if (!osmo_timer_pending(&paging_bts->work_timer))
osmo_timer_schedule(&paging_bts->work_timer, PAGING_TIMER);
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
}
[paging] When giving credit try to send out paging requests too. Make sure the paging timer is restarted after giving some credit and send out paging requests.
2010-04-20 02:59:33 +00:00
static void paging_handle_pending_requests(struct gsm_bts_paging_state *paging_bts);
[paging] When we ran down to 0 available paging slots start a credit timer It might be that we run down to zero available slots but the BTS might not send us a load indication. This can happen if we think we send paging requests and the BTS disagrees and considers them as errors and does not count the paging message. When we drop to zero we will start a credit timer to give us extra credit after six seconds, if we get a CCCH load indication before we will stop the timer.
2010-04-19 11:41:26 +00:00
static void paging_give_credit(void *data)
{
struct gsm_bts_paging_state *paging_bts = data;
logging: introduce LOG_BTS and LOG_TRX and use it everywhere It's quite ugly to have manual "bts=%d" printf-statements all over the BSC code. Let's change this to use shared logging helper functions all over the place, whenever we need to log something related to one BTS or one TRX. This can also help us as the first step to later add alternative logging of BTS identities, e.g. by printing the Cell Global Identifier or LAC+CI, or even a human-readable/vty-defined 'name' of the BTS, rather than its numeric bts number. With this change in place, we can introduce such changes at a single location in the code. Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c
2019-06-13 14:37:24 +00:00
LOG_BTS(paging_bts->bts, DPAG, LOGL_NOTICE, "No PCH LOAD IND, adding 20 slots)\n");
[paging] When we ran down to 0 available paging slots start a credit timer It might be that we run down to zero available slots but the BTS might not send us a load indication. This can happen if we think we send paging requests and the BTS disagrees and considers them as errors and does not count the paging message. When we drop to zero we will start a credit timer to give us extra credit after six seconds, if we get a CCCH load indication before we will stop the timer.
2010-04-19 11:41:26 +00:00
paging_bts->available_slots = 20;
[paging] When giving credit try to send out paging requests too. Make sure the paging timer is restarted after giving some credit and send out paging requests.
2010-04-20 02:59:33 +00:00
paging_handle_pending_requests(paging_bts);
[paging] When we ran down to 0 available paging slots start a credit timer It might be that we run down to zero available slots but the BTS might not send us a load indication. This can happen if we think we send paging requests and the BTS disagrees and considers them as errors and does not count the paging message. When we drop to zero we will start a credit timer to give us extra credit after six seconds, if we get a CCCH load indication before we will stop the timer.
2010-04-19 11:41:26 +00:00
}
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! count the number of free channels for given RSL channel type required
* \param[in] BTS on which we shall count
* \param[in] rsl_type the RSL channel needed type
* \returns number of free channels matching \a rsl_type in \a bts */
[paging] Only page if we have some free channels right now Only page if we have a load that is acceptable for paging. This option is off by default, and can be enabled per bts. The idea is that when we have no resources right now we will not page as it will only create more RACHs and increase the load. By default we are keeping the old behavior to always page and only by changing a setting one is using the new behavior.
2010-09-06 02:11:25 +00:00
static int can_send_pag_req(struct gsm_bts *bts, int rsl_type)
{
struct pchan_load pl;
int count;
memset(&pl, 0, sizeof(pl));
Revert "bts: extend bts_chan_load to allow counting tch only" This reverts commit 308cb0719dca3ba8eed1eff2a2124d44f34d9a28. Problems in this commit: openbsc/src/libbsc/chan_alloc.c:523: case GSM_PCHAN_TCH_F_PDCH: This is actually wrong, GSM_PCHAN_TCH_F_PDCH use ts->flags, not ts->dyn below (due to historical reasons and could be unified). 560: if (only_count_tch && !chan_is_tch(ts)) This has exactly one effect: it excludes GSM_PCHAN_TCH_F_PDCH when in PDCH mode, because for all other PDCH (plain PDCH and TCH/F_TCH/H_PDCH in PDCH mode) below ts_subslots() returns 0 and skips the for() loop. I consider this a bug in TCH/F_PDCH, to be fixed in an upcoming commit. I don't see why we need the only_count_tch argument, because this should normally only count TCH, weren't it for the TCH/F_PDCH bug. If dyn TS should be counted differently, we should do this in a different way. Change-Id: I34dbbaf53a800115e3d03bd44028cad675f3b525
2016-09-25 15:01:20 +00:00
bts_chan_load(&pl, bts);
[paging] Only page if we have some free channels right now Only page if we have a load that is acceptable for paging. This option is off by default, and can be enabled per bts. The idea is that when we have no resources right now we will not page as it will only create more RACHs and increase the load. By default we are keeping the old behavior to always page and only by changing a setting one is using the new behavior.
2010-09-06 02:11:25 +00:00
switch (rsl_type) {
case RSL_CHANNEED_TCH_F:
case RSL_CHANNEED_TCH_ForH:
[paging] Implement the counting for TCH/H and TCH/F Add some code to count TCH/H and TCH/F and also handle the neci bit of the network. Our channel allocator will allocate a TCH/F if we request a TCH/H but can not allocate it.
2010-04-20 09:15:21 +00:00
goto count_tch;
[paging] Only page if we have some free channels right now Only page if we have a load that is acceptable for paging. This option is off by default, and can be enabled per bts. The idea is that when we have no resources right now we will not page as it will only create more RACHs and increase the load. By default we are keeping the old behavior to always page and only by changing a setting one is using the new behavior.
2010-09-06 02:11:25 +00:00
break;
case RSL_CHANNEED_SDCCH:
goto count_sdcch;
break;
case RSL_CHANNEED_ANY:
default:
if (bts->network->pag_any_tch)
[paging] Implement the counting for TCH/H and TCH/F Add some code to count TCH/H and TCH/F and also handle the neci bit of the network. Our channel allocator will allocate a TCH/F if we request a TCH/H but can not allocate it.
2010-04-20 09:15:21 +00:00
goto count_tch;
[paging] Only page if we have some free channels right now Only page if we have a load that is acceptable for paging. This option is off by default, and can be enabled per bts. The idea is that when we have no resources right now we will not page as it will only create more RACHs and increase the load. By default we are keeping the old behavior to always page and only by changing a setting one is using the new behavior.
2010-09-06 02:11:25 +00:00
else
goto count_sdcch;
break;
}
return 0;
/* could available SDCCH */
count_sdcch:
count = 0;
count += pl.pchan[GSM_PCHAN_SDCCH8_SACCH8C].total
- pl.pchan[GSM_PCHAN_SDCCH8_SACCH8C].used;
count += pl.pchan[GSM_PCHAN_CCCH_SDCCH4].total
- pl.pchan[GSM_PCHAN_CCCH_SDCCH4].used;
return bts->paging.free_chans_need > count;
[paging] Implement the counting for TCH/H and TCH/F Add some code to count TCH/H and TCH/F and also handle the neci bit of the network. Our channel allocator will allocate a TCH/F if we request a TCH/H but can not allocate it.
2010-04-20 09:15:21 +00:00
count_tch:
count = 0;
count += pl.pchan[GSM_PCHAN_TCH_F].total
- pl.pchan[GSM_PCHAN_TCH_F].used;
if (bts->network->neci)
count += pl.pchan[GSM_PCHAN_TCH_H].total
- pl.pchan[GSM_PCHAN_TCH_H].used;
return bts->paging.free_chans_need > count;
[paging] Only page if we have some free channels right now Only page if we have a load that is acceptable for paging. This option is off by default, and can be enabled per bts. The idea is that when we have no resources right now we will not page as it will only create more RACHs and increase the load. By default we are keeping the old behavior to always page and only by changing a setting one is using the new behavior.
2010-09-06 02:11:25 +00:00
}
[paging] Send up to avaliable_slots paging requests... Send up to available_slots paging requests but only iterate over the list once. This was not tested on a bts.
2009-02-14 18:05:03 +00:00
/*
* This is kicked by the periodic PAGING LOAD Indicator
* coming from abis_rsl.c
*
* We attempt to iterate once over the list of items but
* only upto available_slots.
*/
[paging] Send paging requests as response to the PAGING LOAD indicator Kill the paging timer and send paging upon paging load notifications.
2009-02-11 01:49:15 +00:00
static void paging_handle_pending_requests(struct gsm_bts_paging_state *paging_bts)
{
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
struct gsm_paging_request *request = NULL;
[paging] Send up to avaliable_slots paging requests... Send up to available_slots paging requests but only iterate over the list once. This was not tested on a bts.
2009-02-14 18:05:03 +00:00
/*
* Determine if the pending_requests list is empty and
* return then.
*/
switch paging code to use a timer again, since not all BTS send reliable CCCH load indications
2009-02-17 01:39:41 +00:00
if (llist_empty(&paging_bts->pending_requests)) {
/* since the list is empty, no need to reschedule the timer */
Hook the paging code into bsc_hack.c and telnet_interface.c Wrote and test code to add and remove paging requests... This will be using the fact that the linux list is building a circle on each tick we can send one/x paging requests and continue round robin...
2009-01-06 23:10:57 +00:00
return;
}
paging: Avoid integer underflow on ipaccess On the nanoBTS we do not receive any load indication for the paging channel and we just decrement our available slots and the unsigned int wraps to the maximum value. Together with a not yet understood bug this makes us go amock. For the nanoBTS and even the Siemens BS11 resetting the load to 20 after two seconds should be just fine. For the nanoBTS we would need to reset the 20 a lot more earlier but we need to take a look at how often we run low.
2010-04-09 16:38:06 +00:00
/*
[paging] When we ran down to 0 available paging slots start a credit timer It might be that we run down to zero available slots but the BTS might not send us a load indication. This can happen if we think we send paging requests and the BTS disagrees and considers them as errors and does not count the paging message. When we drop to zero we will start a credit timer to give us extra credit after six seconds, if we get a CCCH load indication before we will stop the timer.
2010-04-19 11:41:26 +00:00
* In case the BTS does not provide us with load indication and we
* ran out of slots, call an autofill routine. It might be that the
* BTS did not like our paging messages and then we have counted down
* to zero and we do not get any messages.
paging: Avoid integer underflow on ipaccess On the nanoBTS we do not receive any load indication for the paging channel and we just decrement our available slots and the unsigned int wraps to the maximum value. Together with a not yet understood bug this makes us go amock. For the nanoBTS and even the Siemens BS11 resetting the load to 20 after two seconds should be just fine. For the nanoBTS we would need to reset the 20 a lot more earlier but we need to take a look at how often we run low.
2010-04-09 16:38:06 +00:00
*/
if (paging_bts->available_slots == 0) {
src: use osmo_timer_setup() Use new function available in libosmocore to set up timers. Compile tested only. Change-Id: Ibcfd915688e97d370a888888a83a7c95cbe16819
2017-05-08 18:57:52 +00:00
osmo_timer_setup(&paging_bts->credit_timer, paging_give_credit,
paging_bts);
src: use namespace prefix osmo_timer* for timer functions Summary of changes: s/struct timer_list/struct osmo_timer_list/g s/bsc_add_timer/osmo_timer_add/g s/bsc_schedule_timer/osmo_timer_schedule/g s/bsc_del_timer/osmo_timer_del/g s/bsc_timer_pending/osmo_timer_pending/g s/bsc_nearest_timer/osmo_timers_nearest/g s/bsc_prepare_timers/osmo_timers_prepare/g s/bsc_update_timers/osmo_timers_update/g s/bsc_timer_check/osmo_timers_check/g
2011-05-06 10:11:06 +00:00
osmo_timer_schedule(&paging_bts->credit_timer, 5, 0);
[paging] When we ran down to 0 available paging slots start a credit timer It might be that we run down to zero available slots but the BTS might not send us a load indication. This can happen if we think we send paging requests and the BTS disagrees and considers them as errors and does not count the paging message. When we drop to zero we will start a credit timer to give us extra credit after six seconds, if we get a CCCH load indication before we will stop the timer.
2010-04-19 11:41:26 +00:00
return;
paging: Avoid integer underflow on ipaccess On the nanoBTS we do not receive any load indication for the paging channel and we just decrement our available slots and the unsigned int wraps to the maximum value. Together with a not yet understood bug this makes us go amock. For the nanoBTS and even the Siemens BS11 resetting the load to 20 after two seconds should be just fine. For the nanoBTS we would need to reset the 20 a lot more earlier but we need to take a look at how often we run low.
2010-04-09 16:38:06 +00:00
}
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
request = llist_entry(paging_bts->pending_requests.next,
struct gsm_paging_request, entry);
[paging] Send up to avaliable_slots paging requests... Send up to available_slots paging requests but only iterate over the list once. This was not tested on a bts.
2009-02-14 18:05:03 +00:00
[paging] Only page if we have some free channels right now Only page if we have a load that is acceptable for paging. This option is off by default, and can be enabled per bts. The idea is that when we have no resources right now we will not page as it will only create more RACHs and increase the load. By default we are keeping the old behavior to always page and only by changing a setting one is using the new behavior.
2010-09-06 02:11:25 +00:00
/* we need to determine the number of free channels */
if (paging_bts->free_chans_need != -1) {
if (can_send_pag_req(request->bts, request->chan_type) != 0)
goto skip_paging;
}
properly skip paging is OML link is down If the OML link is found down while a paging request is issued, no paging message is sent. However, we were still counting such pagings as an actual attempt, and counted them towards the number of available slots on the paging request queue. Move the OML link check to the caller of page_ms() where the accounting steps can be properly skipped as they should be. Change-Id: I5b6db681da7d45c49e1f2f99d7789c8a29372ef3 Related: OS#2901
2018-04-19 12:39:18 +00:00
/* Skip paging if the bts is down. */
if (!request->bts->oml_link)
goto skip_paging;
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
/* handle the paging request now */
page_ms(request);
paging_bts->available_slots--;
paging: Introduce a GSM_PAGING_BUSY event for a special timeout Start counting the attempts of each paging request and call the callback with the PAGING_BUSY type when the paging request timed out but the subscriber was not paged at all. This can only happen with a huge paging backlog. In case the system has so many pending paging
2010-12-23 17:19:17 +00:00
request->attempts++;
[paging] Send up to avaliable_slots paging requests... Send up to available_slots paging requests but only iterate over the list once. This was not tested on a bts.
2009-02-14 18:05:03 +00:00
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
/* take the current and add it to the back */
llist_del(&request->entry);
llist_add_tail(&request->entry, &paging_bts->pending_requests);
[paging] Simplify the last request and treat llist as a queue The current code was overly complex. It tried to iterate over the list in a round robin and we had to keep track of the last element, see if we remove that one, check if the list becomes empty... This can all replaced by treating the double linked list as a queue. We take the item at the front, do something on it and then and then put it back to the list at the end.
2010-04-09 19:53:35 +00:00
[paging] Only page if we have some free channels right now Only page if we have a load that is acceptable for paging. This option is off by default, and can be enabled per bts. The idea is that when we have no resources right now we will not page as it will only create more RACHs and increase the load. By default we are keeping the old behavior to always page and only by changing a setting one is using the new behavior.
2010-09-06 02:11:25 +00:00
skip_paging:
src: use namespace prefix osmo_timer* for timer functions Summary of changes: s/struct timer_list/struct osmo_timer_list/g s/bsc_add_timer/osmo_timer_add/g s/bsc_schedule_timer/osmo_timer_schedule/g s/bsc_del_timer/osmo_timer_del/g s/bsc_timer_pending/osmo_timer_pending/g s/bsc_nearest_timer/osmo_timers_nearest/g s/bsc_prepare_timers/osmo_timers_prepare/g s/bsc_update_timers/osmo_timers_update/g s/bsc_timer_check/osmo_timers_check/g
2011-05-06 10:11:06 +00:00
osmo_timer_schedule(&paging_bts->work_timer, PAGING_TIMER);
switch paging code to use a timer again, since not all BTS send reliable CCCH load indications
2009-02-17 01:39:41 +00:00
}
static void paging_worker(void *data)
{
struct gsm_bts_paging_state *paging_bts = data;
paging_handle_pending_requests(paging_bts);
Hook the paging code into bsc_hack.c and telnet_interface.c Wrote and test code to add and remove paging requests... This will be using the fact that the linux list is building a circle on each tick we can send one/x paging requests and continue round robin...
2009-01-06 23:10:57 +00:00
}
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! initialize the bts paging state, if it hasn't been initialized yet */
paging: Initialize structs internally to avoid a crash The code to create the struct gsm_bts is in libcommon right now and we can not call paging_init from there. Right now it appears to be the easiest of doing the init internally.
2011-04-26 13:44:57 +00:00
static void paging_init_if_needed(struct gsm_bts *bts)
[paging] Move the paging state into struct gsm_bts There is a 1:1 relationship between gsm_bts and the paging operation. Move the paging state into the gsm_bts which is simplfying the code a lot. This was hinted by LaF0rge. (I'm not happy with the names of the structs)
2009-02-06 18:54:00 +00:00
{
paging: Initialize structs internally to avoid a crash The code to create the struct gsm_bts is in libcommon right now and we can not call paging_init from there. Right now it appears to be the easiest of doing the init internally.
2011-04-26 13:44:57 +00:00
if (bts->paging.bts)
return;
[paging] Move the paging state into struct gsm_bts There is a 1:1 relationship between gsm_bts and the paging operation. Move the paging state into the gsm_bts which is simplfying the code a lot. This was hinted by LaF0rge. (I'm not happy with the names of the structs)
2009-02-06 18:54:00 +00:00
bts->paging.bts = bts;
fix segfault upon release paging on BSSMAP Reset: init llist Initialize the llist head gsm_bts->paging.pending_requests at the time gsm_bts is allocated, not only at paging_init_if_needed(). The gsm_bts->paging sub-struct is invalid as long as gsm_bts->paging.bts doesn't point back to bts. Hence the recently added iteration of gsm_bts->paging.pending_requests should have checked whether bts is NULL. The llist_head pending_requests is not initialized unless paging_init_if_needed() has been called (and paging.bts is hence set). However, this fix is a safer way to prevent errors like this in general. The segfault was introduced by d382bf63e2b7e28fe41c5310c26fe584f0356897 / If3f53d3bb66ad2dc02db823cb813590c6b59c700 Related: OS#2747 Change-Id: Idfafac4e2c0e0a241a62aecbbdc22be71febf840
2017-12-13 18:05:36 +00:00
/* This should be initialized only once. There is currently no code that sets bts->paging.bts
* back to NULL, so let's just assert this one instead of graceful handling. */
OSMO_ASSERT(llist_empty(&bts->paging.pending_requests));
src: use osmo_timer_setup() Use new function available in libosmocore to set up timers. Compile tested only. Change-Id: Ibcfd915688e97d370a888888a83a7c95cbe16819
2017-05-08 18:57:52 +00:00
osmo_timer_setup(&bts->paging.work_timer, paging_worker,
&bts->paging);
[paging] Introduce a variable containing the free paging slots Start with a large number of available slots. It is guranteed that we will - at some point - get a paging load and will properly update the counter and keep it updated.
2009-02-10 00:06:19 +00:00
/* Large number, until we get a proper message */
[paging] Start with a smaller paging limit... The value 20 is just a random number and it really depends on the number of TRX on a bts to be a sane or insane limit.
2010-04-09 20:55:55 +00:00
bts->paging.available_slots = 20;
[paging] Move the paging state into struct gsm_bts There is a 1:1 relationship between gsm_bts and the paging operation. Move the paging state into the gsm_bts which is simplfying the code a lot. This was hinted by LaF0rge. (I'm not happy with the names of the structs)
2009-02-06 18:54:00 +00:00
}
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! do we have any pending paging requests for given subscriber? */
[paging] Cleanup page -> paging in function names
2009-02-09 23:42:03 +00:00
static int paging_pending_request(struct gsm_bts_paging_state *bts,
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
struct bsc_subscr *bsub)
{
[paging] Move the paging state into struct gsm_bts There is a 1:1 relationship between gsm_bts and the paging operation. Move the paging state into the gsm_bts which is simplfying the code a lot. This was hinted by LaF0rge. (I'm not happy with the names of the structs)
2009-02-06 18:54:00 +00:00
struct gsm_paging_request *req;
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
llist_for_each_entry(req, &bts->pending_requests, entry) {
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
if (bsub == req->bsub)
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
return 1;
}
paging: fix whitespace Change-Id: I81c4a9f0dbd708df27a485ef764c9524a36d548a
2018-12-11 13:32:05 +00:00
return 0;
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
}
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! Call-back once T3113 (paging timeout) expires for given paging_request */
* decrease subscriber refcount when free()ing a paging request * use a new timer that stops paging requests after some time, rather than sending them indefinitely
2009-02-10 17:35:04 +00:00
static void paging_T3113_expired(void *data)
{
[paging] Initiliaze req in paging_T3113_expired
2009-02-14 18:04:59 +00:00
struct gsm_paging_request *req = (struct gsm_paging_request *)data;
* decrease subscriber refcount when free()ing a paging request * use a new timer that stops paging requests after some time, rather than sending them indefinitely
2009-02-10 17:35:04 +00:00
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
log_set_context(LOG_CTX_BSC_SUBSCR, req->bsub);
logging: Set the context for paging requests as well.
2014-12-28 14:00:36 +00:00
[paging] Move code to use LOGP and print some more information
2010-04-09 20:02:39 +00:00
LOGP(DPAG, LOGL_INFO, "T3113 expired for request %p (%s)\n",
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
req, bsc_subscr_name(req->bsub));
modify the signal handler/dispatch code (sorry zecke, no offense, I just had some different ideas) * introduce new notion of subsystem in addition to signal number * no need for bitmasks of 'areas' (aka subsystems) * pass subsystem/signal_nr/... per argument rather than by data structure
2009-02-16 22:05:44 +00:00
[paging] In expiration handling remove the request before doing the callback Not doing this could lead to a double deletion due the paging request being removed during the callback and afterwards as well. Change the code to save the callback data, remove the request, do the callback. A patch was proposed by Andreas Eversberg and this one is based on it.
2009-11-17 09:16:46 +00:00
/* must be destroyed before calling cbfn, to prevent double free */
libbsc: paging: more reasonable (and detailed) paging statistics Counting the number of T3113 expirations (one per subscriber per BTS) vs the number of paging attempts (Bsc global) is a ueseless figure, as you cannot relate each other. We count on the BSC level: * how many PAGING we received from the MSC (total) * how many of those were for cells/LACs we don't serve * how many of those resulted in PAGING RESPONSE We count on the BTS leve: * how many PAGING CMD we sent to the BTS (total) * how many of those we ignored as we were already paging * how many of those resulted in PAGING RESPONSE * how many were expired due to T3113 expiring Change-Id: I410bbcbb2621f95f11238f7a5da01ab438f5fee1
2017-12-13 22:17:16 +00:00
rate_ctr_inc(&req->bts->bts_ctrs->ctr[BTS_CTR_PAGING_EXPIRED]);
paging: Introduce a GSM_PAGING_BUSY event for a special timeout Start counting the attempts of each paging request and call the callback with the PAGING_BUSY type when the paging request timed out but the subscriber was not paged at all. This can only happen with a huge paging backlog. In case the system has so many pending paging
2010-12-23 17:19:17 +00:00
/* destroy it now. Do not access req afterwards */
* decrease subscriber refcount when free()ing a paging request * use a new timer that stops paging requests after some time, rather than sending them indefinitely
2009-02-10 17:35:04 +00:00
paging_remove_request(&req->bts->paging, req);
paging: Properly enclose logging imsi filter scope Otherwise all logging is kept enabled after passing through those code paths. Change-Id: I06a977d97e6ffea02ec7402d48410c0e7cc6c155
2018-12-11 13:17:46 +00:00
log_set_context(LOG_CTX_BSC_SUBSCR, NULL);
* decrease subscriber refcount when free()ing a paging request * use a new timer that stops paging requests after some time, rather than sending them indefinitely
2009-02-10 17:35:04 +00:00
}
paging: Add VTY options to calculate T3113 timeout dynamically The idea is to have a base static value which is set like before "timer t3113 [seconds]", but now have a part of this timeout calculated dynamically based on BTS channel configuration and channel load. This patch only implements initial support to calculate based on channel configuration, but doesn't include code to calculate based on channel load. To implement the later part, we probably need to keep track of BTS paging queues per paging group, which we don't do nowadays. Dynamic calculation is enabled by default, and default static base value is decreased accordingly. This way, in a typical setup were the default 10 seconds were used, now the calculated final value is 11 seconds. That's intended because it was observed experimentally in osmo-gsm-tester with a similar channel setup that sometimes paging response can arrive slightly later than 10 seconds. Related: OS#3680 Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
2018-11-07 13:19:32 +00:00
#define GSM_FRAME_DURATION_us 4615
#define GSM51_MFRAME_DURATION_us (51 * GSM_FRAME_DURATION_us) /* 235365 us */
static unsigned int calculate_timer_3113(struct gsm_bts *bts)
{
unsigned int to_us, to;
use libosmocore osmo_tdef Move the T_defs API to libosmocore as osmo_tdefs: remove the local T_defs API and use libosmocore's osmo_tdef* API instead. The root reason is moving the mgw_endpoint_fsm to libosmo-mgcp-client to be able to use it in osmo-msc for inter-MSC handover. When adding osmo_tdef, the new concept of timer groups was added to the API. It would make sense to apply group names here as well, but do not modify the VTY configuration for timers. The future might bring separate groups (or not). Depends: Ibd6b1ed7f1bd6e1f2e0fde53352055a4468f23e5 (libosmocore) Change-Id: I66674a5d8403d820038762888c846bae10ceac58
2019-01-28 02:52:14 +00:00
struct osmo_tdef *d = osmo_tdef_get_entry(bts->network->T_defs, 3113);
paging: Add VTY options to calculate T3113 timeout dynamically The idea is to have a base static value which is set like before "timer t3113 [seconds]", but now have a part of this timeout calculated dynamically based on BTS channel configuration and channel load. This patch only implements initial support to calculate based on channel configuration, but doesn't include code to calculate based on channel load. To implement the later part, we probably need to keep track of BTS paging queues per paging group, which we don't do nowadays. Dynamic calculation is enabled by default, and default static base value is decreased accordingly. This way, in a typical setup were the default 10 seconds were used, now the calculated final value is 11 seconds. That's intended because it was observed experimentally in osmo-gsm-tester with a similar channel setup that sometimes paging response can arrive slightly later than 10 seconds. Related: OS#3680 Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
2018-11-07 13:19:32 +00:00
paging: fix nullpointer deref In theroy the function T_def_get_entry() may return a nullpointer. In this case we would run straight into a nullpointer dereference problem. However, the requested timer is statically defined and should always be there. However Coverity still reports this as a problem. Lets put an OSMO_ASSERT to make clear that there is no problem here. Fixes: CID#190403 Change-Id: If5238132d9d5a1507b9955a0b2dc4b1bced220e8
2019-01-08 12:04:41 +00:00
/* Note: d should always contain a valid pointer since all timers,
* including 3113 are statically pre-defined in
use libosmocore osmo_tdef Move the T_defs API to libosmocore as osmo_tdefs: remove the local T_defs API and use libosmocore's osmo_tdef* API instead. The root reason is moving the mgw_endpoint_fsm to libosmo-mgcp-client to be able to use it in osmo-msc for inter-MSC handover. When adding osmo_tdef, the new concept of timer groups was added to the API. It would make sense to apply group names here as well, but do not modify the VTY configuration for timers. The future might bring separate groups (or not). Depends: Ibd6b1ed7f1bd6e1f2e0fde53352055a4468f23e5 (libosmocore) Change-Id: I66674a5d8403d820038762888c846bae10ceac58
2019-01-28 02:52:14 +00:00
* struct osmo_tdef gsm_network_T_defs. */
paging: fix nullpointer deref In theroy the function T_def_get_entry() may return a nullpointer. In this case we would run straight into a nullpointer dereference problem. However, the requested timer is statically defined and should always be there. However Coverity still reports this as a problem. Lets put an OSMO_ASSERT to make clear that there is no problem here. Fixes: CID#190403 Change-Id: If5238132d9d5a1507b9955a0b2dc4b1bced220e8
2019-01-08 12:04:41 +00:00
OSMO_ASSERT(d);
paging: Add VTY options to calculate T3113 timeout dynamically The idea is to have a base static value which is set like before "timer t3113 [seconds]", but now have a part of this timeout calculated dynamically based on BTS channel configuration and channel load. This patch only implements initial support to calculate based on channel configuration, but doesn't include code to calculate based on channel load. To implement the later part, we probably need to keep track of BTS paging queues per paging group, which we don't do nowadays. Dynamic calculation is enabled by default, and default static base value is decreased accordingly. This way, in a typical setup were the default 10 seconds were used, now the calculated final value is 11 seconds. That's intended because it was observed experimentally in osmo-gsm-tester with a similar channel setup that sometimes paging response can arrive slightly later than 10 seconds. Related: OS#3680 Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
2018-11-07 13:19:32 +00:00
if (!bts->T3113_dynamic)
return d->val;
/* TODO: take into account load of paging group for req->bsub */
/* MFRMS defines repeat interval of paging messages for MSs that belong
Fix some typos Fix typos and common misspellings in code comments and in the manual. Change-Id: I46fc9d424620c77ae9ccf78b58081bd303386d7c
2019-11-13 21:10:41 +00:00
* to same paging group across multiple 51 frame multiframes.
paging: Add VTY options to calculate T3113 timeout dynamically The idea is to have a base static value which is set like before "timer t3113 [seconds]", but now have a part of this timeout calculated dynamically based on BTS channel configuration and channel load. This patch only implements initial support to calculate based on channel configuration, but doesn't include code to calculate based on channel load. To implement the later part, we probably need to keep track of BTS paging queues per paging group, which we don't do nowadays. Dynamic calculation is enabled by default, and default static base value is decreased accordingly. This way, in a typical setup were the default 10 seconds were used, now the calculated final value is 11 seconds. That's intended because it was observed experimentally in osmo-gsm-tester with a similar channel setup that sometimes paging response can arrive slightly later than 10 seconds. Related: OS#3680 Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
2018-11-07 13:19:32 +00:00
* MAXTRANS defines maximum number of RACH retransmissions.
*/
to_us = GSM51_MFRAME_DURATION_us * (bts->si_common.chan_desc.bs_pa_mfrms + 2) *
bts->si_common.rach_control.max_trans;
/* ceiling in seconds + extra time */
to = (to_us + 999999) / 1000000 + d->val;
logging: introduce LOG_BTS and LOG_TRX and use it everywhere It's quite ugly to have manual "bts=%d" printf-statements all over the BSC code. Let's change this to use shared logging helper functions all over the place, whenever we need to log something related to one BTS or one TRX. This can also help us as the first step to later add alternative logging of BTS identities, e.g. by printing the Cell Global Identifier or LAC+CI, or even a human-readable/vty-defined 'name' of the BTS, rather than its numeric bts number. With this change in place, we can introduce such changes at a single location in the code. Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c
2019-06-13 14:37:24 +00:00
LOG_BTS(bts, DPAG, LOGL_DEBUG, "Paging request: T3113 expires in %u seconds\n", to);
paging: Add VTY options to calculate T3113 timeout dynamically The idea is to have a base static value which is set like before "timer t3113 [seconds]", but now have a part of this timeout calculated dynamically based on BTS channel configuration and channel load. This patch only implements initial support to calculate based on channel configuration, but doesn't include code to calculate based on channel load. To implement the later part, we probably need to keep track of BTS paging queues per paging group, which we don't do nowadays. Dynamic calculation is enabled by default, and default static base value is decreased accordingly. This way, in a typical setup were the default 10 seconds were used, now the calculated final value is 11 seconds. That's intended because it was observed experimentally in osmo-gsm-tester with a similar channel setup that sometimes paging response can arrive slightly later than 10 seconds. Related: OS#3680 Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
2018-11-07 13:19:32 +00:00
return to;
}
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! Start paging + paging timer for given subscriber on given BTS
* \param bts BTS on which to page
* \param[in] bsub subscriber we want to page
* \param[in] type type of radio channel we're requirign
paging: Remove obsolete paging call-back support The call-back was needed inside the NITB to determine which part (CC, SMS, ...) had triggered a given paging. A pure BSC doesn't need that feature, so let's get rid of it. The 'void *cbfn_data' is replaced with a 'struct bsc_msc_data *', as all callers use it with that type. Change-Id: I8839e8338d3ad1a91b41e687e8412fcdca3fd9ab
2017-12-11 14:21:48 +00:00
* \param[in] msc MSC which has issue this paging
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
* \returns 0 on success, negative on error */
refactor paging: add bsc_subscr to bsc_paging_params Get a bsub once at start of paging. Change-Id: I13621cd51d934846ff6556e1f2f8839da73a5dbb
2020-09-18 02:02:13 +00:00
static int _paging_request(const struct bsc_paging_params *params, struct gsm_bts *bts)
* introduce a callback function when paging completes (I know this is somewhat of an overlap with the signals, but I think paging always has one reason and thus one caller wants to get notified about completion, including a caller-specific context, etc) * introduce TLV parser definitions for GSM 04.08 * parse and generate BCD number IE's for 04.08 call control
2009-02-16 22:52:23 +00:00
{
[paging] Move the paging state into struct gsm_bts There is a 1:1 relationship between gsm_bts and the paging operation. Move the paging state into the gsm_bts which is simplfying the code a lot. This was hinted by LaF0rge. (I'm not happy with the names of the structs)
2009-02-06 18:54:00 +00:00
struct gsm_bts_paging_state *bts_entry = &bts->paging;
struct gsm_paging_request *req;
paging: Add VTY options to calculate T3113 timeout dynamically The idea is to have a base static value which is set like before "timer t3113 [seconds]", but now have a part of this timeout calculated dynamically based on BTS channel configuration and channel load. This patch only implements initial support to calculate based on channel configuration, but doesn't include code to calculate based on channel load. To implement the later part, we probably need to keep track of BTS paging queues per paging group, which we don't do nowadays. Dynamic calculation is enabled by default, and default static base value is decreased accordingly. This way, in a typical setup were the default 10 seconds were used, now the calculated final value is 11 seconds. That's intended because it was observed experimentally in osmo-gsm-tester with a similar channel setup that sometimes paging response can arrive slightly later than 10 seconds. Related: OS#3680 Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
2018-11-07 13:19:32 +00:00
unsigned int t3113_timeout_s;
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
libbsc: paging: more reasonable (and detailed) paging statistics Counting the number of T3113 expirations (one per subscriber per BTS) vs the number of paging attempts (Bsc global) is a ueseless figure, as you cannot relate each other. We count on the BSC level: * how many PAGING we received from the MSC (total) * how many of those were for cells/LACs we don't serve * how many of those resulted in PAGING RESPONSE We count on the BTS leve: * how many PAGING CMD we sent to the BTS (total) * how many of those we ignored as we were already paging * how many of those resulted in PAGING RESPONSE * how many were expired due to T3113 expiring Change-Id: I410bbcbb2621f95f11238f7a5da01ab438f5fee1
2017-12-13 22:17:16 +00:00
rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_ATTEMPTED]);
refactor paging: add bsc_subscr to bsc_paging_params Get a bsub once at start of paging. Change-Id: I13621cd51d934846ff6556e1f2f8839da73a5dbb
2020-09-18 02:02:13 +00:00
if (paging_pending_request(bts_entry, params->bsub)) {
refactor paging: introduce bsc_paging_params For LCS, I would like to add an enum indicating the paging reason. Instead of modifying extremely many function signatures to pass the reason across all levels of paging, introduce a struct combining these. Change-Id: I27ca78fc6ff8ef1101554c0a8429e34945ca6f3c
2020-09-18 00:49:15 +00:00
LOG_PAGING_BTS(params, bts, DPAG, LOGL_INFO, "Paging request already pending for this subscriber\n");
libbsc: paging: more reasonable (and detailed) paging statistics Counting the number of T3113 expirations (one per subscriber per BTS) vs the number of paging attempts (Bsc global) is a ueseless figure, as you cannot relate each other. We count on the BSC level: * how many PAGING we received from the MSC (total) * how many of those were for cells/LACs we don't serve * how many of those resulted in PAGING RESPONSE We count on the BTS leve: * how many PAGING CMD we sent to the BTS (total) * how many of those we ignored as we were already paging * how many of those resulted in PAGING RESPONSE * how many were expired due to T3113 expiring Change-Id: I410bbcbb2621f95f11238f7a5da01ab438f5fee1
2017-12-13 22:17:16 +00:00
rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_ALREADY]);
provide return code from paging_request() function this enables the caller to detect if the paging request was rejected by the paging layer, especially in case it is already paging this very subscriber. In the case of SMS / 04.11, we used to have a memory leak of struct gsm_sms's, since we would only free them from the paging succeeded/expired callbacks.
2009-08-15 01:16:17 +00:00
return -EEXIST;
[paging] Do not create a request when one is already pending... This is removing a memleak, saving some mallocs and a crash in the timer expired function that attempted to remove the paging_request from a list it was not in....
2009-02-14 23:53:20 +00:00
}
refactor paging: introduce bsc_paging_params For LCS, I would like to add an enum indicating the paging reason. Instead of modifying extremely many function signatures to pass the reason across all levels of paging, introduce a struct combining these. Change-Id: I27ca78fc6ff8ef1101554c0a8429e34945ca6f3c
2020-09-18 00:49:15 +00:00
LOG_PAGING_BTS(params, bts, DPAG, LOGL_DEBUG, "Start paging\n");
use taloc_zero() rather than talloc() and explisit memset()
2009-06-26 18:25:23 +00:00
req = talloc_zero(tall_paging_ctx, struct gsm_paging_request);
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
OSMO_ASSERT(req);
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
req->reason = params->reason;
introduce osmo_use_count for bsc_subscr During LCS development, I'm getting use count bugs and would like to see use token strings to figure it out. Change-Id: I29bf60059d4cf7bb99a00753e6cdc149baf95f94
2020-09-15 01:03:58 +00:00
req->bsub = params->bsub;
bsc_subscr_get(req->bsub, BSUB_USE_PAGING_REQUEST);
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
req->bts = bts;
refactor paging: introduce bsc_paging_params For LCS, I would like to add an enum indicating the paging reason. Instead of modifying extremely many function signatures to pass the reason across all levels of paging, introduce a struct combining these. Change-Id: I27ca78fc6ff8ef1101554c0a8429e34945ca6f3c
2020-09-18 00:49:15 +00:00
req->chan_type = params->chan_needed;
req->msc = params->msc;
src: use osmo_timer_setup() Use new function available in libosmocore to set up timers. Compile tested only. Change-Id: Ibcfd915688e97d370a888888a83a7c95cbe16819
2017-05-08 18:57:52 +00:00
osmo_timer_setup(&req->T3113, paging_T3113_expired, req);
paging: Add VTY options to calculate T3113 timeout dynamically The idea is to have a base static value which is set like before "timer t3113 [seconds]", but now have a part of this timeout calculated dynamically based on BTS channel configuration and channel load. This patch only implements initial support to calculate based on channel configuration, but doesn't include code to calculate based on channel load. To implement the later part, we probably need to keep track of BTS paging queues per paging group, which we don't do nowadays. Dynamic calculation is enabled by default, and default static base value is decreased accordingly. This way, in a typical setup were the default 10 seconds were used, now the calculated final value is 11 seconds. That's intended because it was observed experimentally in osmo-gsm-tester with a similar channel setup that sometimes paging response can arrive slightly later than 10 seconds. Related: OS#3680 Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
2018-11-07 13:19:32 +00:00
t3113_timeout_s = calculate_timer_3113(bts);
osmo_timer_schedule(&req->T3113, t3113_timeout_s, 0);
[paging] Do not create a request when one is already pending... This is removing a memleak, saving some mallocs and a crash in the timer expired function that attempted to remove the paging_request from a list it was not in....
2009-02-14 23:53:20 +00:00
llist_add_tail(&req->entry, &bts_entry->pending_requests);
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
paging_schedule_if_needed(bts_entry);
provide return code from paging_request() function this enables the caller to detect if the paging request was rejected by the paging layer, especially in case it is already paging this very subscriber. In the case of SMS / 04.11, we used to have a memory leak of struct gsm_sms's, since we would only free them from the paging succeeded/expired callbacks.
2009-08-15 01:16:17 +00:00
return 0;
Start creating a paging layer... You can request to open a channel to a MS and the paging layer will call you once the channel is allocated. Internally the CCCH Load Indication will be handled and retry to page a terminal.
2009-01-06 21:47:18 +00:00
}
add new routine to stop paging
2009-02-06 12:52:14 +00:00
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! Handle PAGING request from MSC for one (matching) BTS
* \param bts BTS on which to page
* \param[in] bsub subscriber we want to page
* \param[in] type type of radio channel we're requirign
paging: Remove obsolete paging call-back support The call-back was needed inside the NITB to determine which part (CC, SMS, ...) had triggered a given paging. A pure BSC doesn't need that feature, so let's get rid of it. The 'void *cbfn_data' is replaced with a 'struct bsc_msc_data *', as all callers use it with that type. Change-Id: I8839e8338d3ad1a91b41e687e8412fcdca3fd9ab
2017-12-11 14:21:48 +00:00
* \param[in] msc MSC which has issue this paging
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
* returns 1 on success; 0 in case of error (e.g. TRX down) */
refactor paging: add bsc_subscr to bsc_paging_params Get a bsub once at start of paging. Change-Id: I13621cd51d934846ff6556e1f2f8839da73a5dbb
2020-09-18 02:02:13 +00:00
int paging_request_bts(const struct bsc_paging_params *params, struct gsm_bts *bts)
bsc: Allow to page a BTS that is excluded from the RF lock The RF lock excluded BTS was not paged at all. Now forward the paging message to the handler and call a function that will check if this LAC can be paged right now. Introduce a new paging method that allows to page on a dedicated bts, refactor the code to use this method for paging.
2013-01-07 16:30:13 +00:00
{
int rc;
/* skip all currently inactive TRX */
if (!trx_is_usable(bts->c0))
return 0;
/* maybe it is the first time we use it */
paging_init_if_needed(bts);
/* Trigger paging, pass any error to the caller */
refactor paging: add bsc_subscr to bsc_paging_params Get a bsub once at start of paging. Change-Id: I13621cd51d934846ff6556e1f2f8839da73a5dbb
2020-09-18 02:02:13 +00:00
rc = _paging_request(params, bts);
bsc: Allow to page a BTS that is excluded from the RF lock The RF lock excluded BTS was not paged at all. Now forward the paging message to the handler and call a function that will check if this LAC can be paged right now. Introduce a new paging method that allows to page on a dedicated bts, refactor the code to use this method for paging.
2013-01-07 16:30:13 +00:00
if (rc < 0)
paging: paging_request_bts: Fix wrong return value Change-Id: I48f5efbcddd98e15256edfca06ba0ae6acb5bab1
2018-03-26 16:33:35 +00:00
return 0;
bsc: Allow to page a BTS that is excluded from the RF lock The RF lock excluded BTS was not paged at all. Now forward the paging message to the handler and call a function that will check if this LAC can be paged right now. Introduce a new paging method that allows to page on a dedicated bts, refactor the code to use this method for paging.
2013-01-07 16:30:13 +00:00
return 1;
}
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! Stop paging a given subscriber on a given BTS.
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
* \param[out] returns the MSC that paged the subscriber, if any.
* \param[out] returns the reason for a pending paging, if any.
* \param[in] bts BTS which has received a paging response.
* \param[in] bsub subscriber.
* \returns number of pending pagings.
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
*/
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
static int paging_request_stop_bts(struct bsc_msc_data **msc_p, enum bsc_paging_reason *reason_p,
struct gsm_bts *bts, struct bsc_subscr *bsub)
add new routine to stop paging
2009-02-06 12:52:14 +00:00
{
[paging] Move the paging state into struct gsm_bts There is a 1:1 relationship between gsm_bts and the paging operation. Move the paging state into the gsm_bts which is simplfying the code a lot. This was hinted by LaF0rge. (I'm not happy with the names of the structs)
2009-02-06 18:54:00 +00:00
struct gsm_bts_paging_state *bts_entry = &bts->paging;
struct gsm_paging_request *req, *req2;
add new routine to stop paging
2009-02-06 12:52:14 +00:00
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
*msc_p = NULL;
*reason_p = BSC_PAGING_NONE;
paging: Initialize structs internally to avoid a crash The code to create the struct gsm_bts is in libcommon right now and we can not call paging_init from there. Right now it appears to be the easiest of doing the init internally.
2011-04-26 13:44:57 +00:00
paging_init_if_needed(bts);
add new routine to stop paging
2009-02-06 12:52:14 +00:00
llist_for_each_entry_safe(req, req2, &bts_entry->pending_requests,
add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
2017-02-18 21:20:46 +00:00
entry) {
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
if (req->bsub != bsub)
continue;
*msc_p = req->msc;
*reason_p = req->reason;
LOG_BTS(bts, DPAG, LOGL_DEBUG, "Stop paging %s\n", bsc_subscr_name(bsub));
paging_remove_request(&bts->paging, req);
return 1;
add new routine to stop paging
2009-02-06 12:52:14 +00:00
}
increment 'paging responded' counter for active paging only Only count paging responses which can be mapped to an active paging. Unsolicited paging responses which do not correspond to an active paging would increment the 'paging response' counter. This means the number of paging attempts could be smaller than the number of paging responses, which can look confusing in the 'show statistics' VTY command. Change-Id: I7cfc7c29fb7570d41e3ac23cca17f5b98b303506 Related: OS#66
2018-06-07 15:09:45 +00:00
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
return 0;
add new routine to stop paging
2009-02-06 12:52:14 +00:00
}
[paging] Introduce a variable containing the free paging slots Start with a large number of available slots. It is guranteed that we will - at some point - get a paging load and will properly update the counter and keep it updated.
2009-02-10 00:06:19 +00:00
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
/*! Stop paging on all cells and return the MSC that paged (if any) and all pending paging reasons.
* \param[out] returns the MSC that paged the subscriber, if there was a pending request.
* \param[out] returns the ORed bitmask of all reasons of pending pagings.
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
* \param[in] bts BTS which has received a paging response
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
* \param[in] bsub subscriber
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
* \returns number of pending pagings.
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
*/
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
int paging_request_stop(struct bsc_msc_data **msc_p, enum bsc_paging_reason *reasons_p,
struct gsm_bts *bts, struct bsc_subscr *bsub)
Move the "finding" of the right BTS into paging.c Move the secret of how to find the BTS in a LocationArea into the paging layer. This allows to implement different strategies without changing other parts. E.g. we might want to try the BTS were the device was seen last and then try... There should be no semantic change and things should continue to work. It is sadly not tested though.
2009-06-10 00:45:42 +00:00
{
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
struct gsm_bts *bts_i;
struct bsc_msc_data *paged_from_msc;
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
int count;
enum bsc_paging_reason reasons;
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
OSMO_ASSERT(bts);
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
count = paging_request_stop_bts(&paged_from_msc, &reasons, bts, bsub);
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
if (paged_from_msc) {
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
count++;
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_RESPONDED]);
rate_ctr_inc(&bts->network->bsc_ctrs->ctr[BSC_CTR_PAGING_RESPONDED]);
}
logging: Set the context for paging requests as well.
2014-12-28 14:00:36 +00:00
compl l3: move Paging Response handling out of bsc_find_msc() Instead of iterating the llist of gsm_paging_requests first to find an MSC, and then again right away to mark the paging as served, do both in the same step. Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041
2020-09-12 01:01:58 +00:00
llist_for_each_entry(bts_i, &bsc_gsmnet->bts_list, list) {
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
struct bsc_msc_data *paged_from_msc2;
enum bsc_paging_reason reason2;
count += paging_request_stop_bts(&paged_from_msc2, &reason2, bts_i, bsub);
if (paged_from_msc2) {
reasons |= reason2;
if (!paged_from_msc) {
/* If this happened, it would be a bit weird: it means there was no Paging Request
* pending on the BTS that sent the Paging Reponse, but there *is* a Paging Request
* pending on a different BTS. But why not return an MSC when we found one. */
paged_from_msc = paged_from_msc2;
}
increment 'paging responded' counter for active paging only Only count paging responses which can be mapped to an active paging. Unsolicited paging responses which do not correspond to an active paging would increment the 'paging response' counter. This means the number of paging attempts could be smaller than the number of paging responses, which can look confusing in the 'show statistics' VTY command. Change-Id: I7cfc7c29fb7570d41e3ac23cca17f5b98b303506 Related: OS#66
2018-06-07 15:09:45 +00:00
}
libbsc: paging: more reasonable (and detailed) paging statistics Counting the number of T3113 expirations (one per subscriber per BTS) vs the number of paging attempts (Bsc global) is a ueseless figure, as you cannot relate each other. We count on the BSC level: * how many PAGING we received from the MSC (total) * how many of those were for cells/LACs we don't serve * how many of those resulted in PAGING RESPONSE We count on the BTS leve: * how many PAGING CMD we sent to the BTS (total) * how many of those we ignored as we were already paging * how many of those resulted in PAGING RESPONSE * how many were expired due to T3113 expiring Change-Id: I410bbcbb2621f95f11238f7a5da01ab438f5fee1
2017-12-13 22:17:16 +00:00
}
[paging] Unbreak breakge when moving things into paging.c By calling _paging_request_stop with NULL for the lchan we have never used the paging complete callback... I didn't spot that when moving the code over and thought it is a great simplification to not call paging_request_stop first and then loop... *sigh* restore the old behaviour. Call the callback first and then free the requests.
2009-06-10 09:46:58 +00:00
LCS: add paging reason, return in paging_request_stop() To distinguish between the CN requiring a Complete Layer 3 response, or just the BSC requiring a TA, allow recording a separate for-LCS paging reason. Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
2020-09-18 00:49:21 +00:00
*msc_p = paged_from_msc;
*reasons_p = reasons;
return count;
Move the "finding" of the right BTS into paging.c Move the secret of how to find the BTS in a LocationArea into the paging layer. This allows to implement different strategies without changing other parts. E.g. we might want to try the BTS were the device was seen last and then try... There should be no semantic change and things should continue to work. It is sadly not tested though.
2009-06-10 00:45:42 +00:00
}
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! Update the BTS paging buffer slots on given BTS */
misc: Move from u_int to uint types of stdint.h This was done with sed on the files.
2011-04-18 15:04:00 +00:00
void paging_update_buffer_space(struct gsm_bts *bts, uint16_t free_slots)
[paging] Introduce a variable containing the free paging slots Start with a large number of available slots. It is guranteed that we will - at some point - get a paging load and will properly update the counter and keep it updated.
2009-02-10 00:06:19 +00:00
{
paging: Initialize structs internally to avoid a crash The code to create the struct gsm_bts is in libcommon right now and we can not call paging_init from there. Right now it appears to be the easiest of doing the init internally.
2011-04-26 13:44:57 +00:00
paging_init_if_needed(bts);
src: use namespace prefix osmo_timer* for timer functions Summary of changes: s/struct timer_list/struct osmo_timer_list/g s/bsc_add_timer/osmo_timer_add/g s/bsc_schedule_timer/osmo_timer_schedule/g s/bsc_del_timer/osmo_timer_del/g s/bsc_timer_pending/osmo_timer_pending/g s/bsc_nearest_timer/osmo_timers_nearest/g s/bsc_prepare_timers/osmo_timers_prepare/g s/bsc_update_timers/osmo_timers_update/g s/bsc_timer_check/osmo_timers_check/g
2011-05-06 10:11:06 +00:00
osmo_timer_del(&bts->paging.credit_timer);
[paging] Introduce a variable containing the free paging slots Start with a large number of available slots. It is guranteed that we will - at some point - get a paging load and will properly update the counter and keep it updated.
2009-02-10 00:06:19 +00:00
bts->paging.available_slots = free_slots;
[paging] Continuisly send paging commands. Instead of throwing a huge pile of paging commands to the BTS we will submit one paging command every half second. This way we can have different messages between the paging commands. This is done to avoid crashes of the nanoBTS when too much paging messages are send.
2010-09-06 02:05:23 +00:00
paging_schedule_if_needed(&bts->paging);
[paging] Introduce a variable containing the free paging slots Start with a large number of available slots. It is guranteed that we will - at some point - get a paging load and will properly update the counter and keep it updated.
2009-02-10 00:06:19 +00:00
}
paging: Provide the number of pending requests Address the FIXME and take code from the on-waves/bsc-master branch. This will count the number of requests.
2011-04-26 13:52:34 +00:00
paging.c: add more documentation on what the functions actually do This was created during code review towards some upcoming fix for OS#2736. However, it's not really related to that. Change-Id: I68d4fc8baaedd1d64cd628b2441c57ebc64ecebc
2017-12-11 13:25:08 +00:00
/*! Count the number of pending paging requests on given BTS */
paging: Provide the number of pending requests Address the FIXME and take code from the on-waves/bsc-master branch. This will count the number of requests.
2011-04-26 13:52:34 +00:00
unsigned int paging_pending_requests_nr(struct gsm_bts *bts)
{
unsigned int requests = 0;
struct gsm_paging_request *req;
paging_init_if_needed(bts);
llist_for_each_entry(req, &bts->paging.pending_requests, entry)
++requests;
return requests;
}
paging: Add method to find the paging data for a given subscriber
2011-06-07 17:53:29 +00:00
extend documentation of paging_flush_bts() Document the semantics of a NULL msc argument. Change-Id: Ib3f6fd4e4e6108f03d688eba2416c0714393e6e9 Related: OS#2901
2018-04-19 12:26:09 +00:00
/*! Flush all paging requests at a given BTS for a given MSC (or NULL if all MSC should be flushed). */
paging: Stop all paging if MSC sends us BSSMAP RESET When the MSC has lost its state and issues a RESET, we should not only clear all ongoing radio connections, but we should also stop any paging. There's no point in paging a subscriber if the MSC doesn't know about this paging anymore. Change-Id: If3f53d3bb66ad2dc02db823cb813590c6b59c700 Closes: OS#2736
2017-12-11 14:33:35 +00:00
void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc)
{
struct gsm_paging_request *req, *req2;
stats: Count paging requests flushed due to MSC Reset. Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b
2020-05-22 18:43:57 +00:00
int num_cancelled = 0;
paging: Stop all paging if MSC sends us BSSMAP RESET When the MSC has lost its state and issues a RESET, we should not only clear all ongoing radio connections, but we should also stop any paging. There's no point in paging a subscriber if the MSC doesn't know about this paging anymore. Change-Id: If3f53d3bb66ad2dc02db823cb813590c6b59c700 Closes: OS#2736
2017-12-11 14:33:35 +00:00
paging: paging_flush_bts: be sure pending_requests is initalized The BSSMAP reset causes the paging requests to be flushed. When this happens right after startup then calling paging_flush_bts() may be called when the list bts->paging.pending_requests is not yet initalized, which causes a segfault. Call paging_init_if_needed() to be sure that the list is inizalized (like the other functions also do) Change-Id: I42ddbfdec6f9d74d858ad13cc38b5b64061d08dc
2017-12-13 14:33:25 +00:00
paging_init_if_needed(bts);
paging: Stop all paging if MSC sends us BSSMAP RESET When the MSC has lost its state and issues a RESET, we should not only clear all ongoing radio connections, but we should also stop any paging. There's no point in paging a subscriber if the MSC doesn't know about this paging anymore. Change-Id: If3f53d3bb66ad2dc02db823cb813590c6b59c700 Closes: OS#2736
2017-12-11 14:33:35 +00:00
llist_for_each_entry_safe(req, req2, &bts->paging.pending_requests, entry) {
if (msc && req->msc != msc)
continue;
/* now give up the data structure */
logging: introduce LOG_BTS and LOG_TRX and use it everywhere It's quite ugly to have manual "bts=%d" printf-statements all over the BSC code. Let's change this to use shared logging helper functions all over the place, whenever we need to log something related to one BTS or one TRX. This can also help us as the first step to later add alternative logging of BTS identities, e.g. by printing the Cell Global Identifier or LAC+CI, or even a human-readable/vty-defined 'name' of the BTS, rather than its numeric bts number. With this change in place, we can introduce such changes at a single location in the code. Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c
2019-06-13 14:37:24 +00:00
LOG_BTS(bts, DPAG, LOGL_DEBUG, "Stop paging %s (flush)\n", bsc_subscr_name(req->bsub));
paging: Stop all paging if MSC sends us BSSMAP RESET When the MSC has lost its state and issues a RESET, we should not only clear all ongoing radio connections, but we should also stop any paging. There's no point in paging a subscriber if the MSC doesn't know about this paging anymore. Change-Id: If3f53d3bb66ad2dc02db823cb813590c6b59c700 Closes: OS#2736
2017-12-11 14:33:35 +00:00
paging_remove_request(&bts->paging, req);
stats: Count paging requests flushed due to MSC Reset. Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b
2020-05-22 18:43:57 +00:00
num_cancelled++;
paging: Stop all paging if MSC sends us BSSMAP RESET When the MSC has lost its state and issues a RESET, we should not only clear all ongoing radio connections, but we should also stop any paging. There's no point in paging a subscriber if the MSC doesn't know about this paging anymore. Change-Id: If3f53d3bb66ad2dc02db823cb813590c6b59c700 Closes: OS#2736
2017-12-11 14:33:35 +00:00
}
stats: Count paging requests flushed due to MSC Reset. Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b
2020-05-22 18:43:57 +00:00
rate_ctr_add(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_MSC_FLUSH], num_cancelled);
paging: Stop all paging if MSC sends us BSSMAP RESET When the MSC has lost its state and issues a RESET, we should not only clear all ongoing radio connections, but we should also stop any paging. There's no point in paging a subscriber if the MSC doesn't know about this paging anymore. Change-Id: If3f53d3bb66ad2dc02db823cb813590c6b59c700 Closes: OS#2736
2017-12-11 14:33:35 +00:00
}
/*! Flush all paging requests issued by \a msc on any BTS in \a net */
void paging_flush_network(struct gsm_network *net, struct bsc_msc_data *msc)
{
struct gsm_bts *bts;
llist_for_each_entry(bts, &net->bts_list, list)
paging_flush_bts(bts, msc);
}