cellular-infrastructure
/
osmo-bsc-nat
mirror of https://gerrit.osmocom.org/osmo-bsc-nat
10
1
Fork 1
Code Issues Releases Wiki Activity

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"osmith replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"osmith replied on the change"}
This commit is contained in:
Gerrit User 1000147 2022-06-08 11:35:04 +00:00 committed by Gerrit Code Review
parent 72cabdf557
commit f75678da27
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
88cc1a2dbad497c84f09ec3b513cdca57b314160
View File

@ -52,6 +52,24 @@
"parentUuid": "ba2b9a7d_efa30c14",
"revId": "88cc1a2dbad497c84f09ec3b513cdca57b314160",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "cbae2127_e8bcd74b",
"filename": "src/osmo-bsc-nat/bssap_conn.c",
"patchSetId": 4
},
"lineNbr": 47,
"author": {
"id": 1000147
},
"writtenOn": "2022-06-08T11:35:04Z",
"side": 1,
"message": "The length of the IE is different depending on IPv4 or IPv6 address being encoded (3GPP TS 48.008 § 3.2.2.102). So I can\u0027t just modify the existing buffer without re-encoding, I\u0027ll implement Neels approach. Thanks for the feedback!",
"parentUuid": "7ada68e1_4223f2f1",
"revId": "88cc1a2dbad497c84f09ec3b513cdca57b314160",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}