cellular-infrastructure
/
osmo-bsc-nat
mirror of https://gerrit.osmocom.org/osmo-bsc-nat
10
1
Fork 1
Code Issues Releases Wiki Activity

Update patch set 6 

Patch Set 6: Code-Review+2

(2 comments)

Patch-set: 6
Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"neels replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"}
This commit is contained in:
Gerrit User 1000005 2022-06-08 17:09:58 +00:00 committed by Gerrit Code Review
parent 21196e8cd9
commit cc5534860a
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
6cda1fe4aef9bba66a5d5ed2602bd0d7a81abc4a
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "c6fc3f01_d5ed874e",
"filename": "include/osmocom/bsc_nat/subscr_conn_fsm.h",
"patchSetId": 6
},
"lineNbr": 31,
"author": {
"id": 1000005
},
"writtenOn": "2022-06-08T17:09:58Z",
"side": 1,
"message": "(doesn\u0027t the linter complain about trailing blank lines?)",
"revId": "6cda1fe4aef9bba66a5d5ed2602bd0d7a81abc4a",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {

18
88cc1a2dbad497c84f09ec3b513cdca57b314160
View File

@ -142,6 +142,24 @@
"parentUuid": "f0165b8f_2b43f1ff",
"revId": "88cc1a2dbad497c84f09ec3b513cdca57b314160",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "04835439_e1639fc9",
"filename": "src/osmo-bsc-nat/bssap_conn.c",
"patchSetId": 4
},
"lineNbr": 47,
"author": {
"id": 1000005
},
"writtenOn": "2022-06-08T17:09:58Z",
"side": 1,
"message": "Pau is correct that it would indeed be possible to copy the part leading up to the changed IE and then copy the remaining part after the changed IE (or even memmove in the existing buffer), but i think it would be more code than the current patch set. i like the simplicity of the current patch set.",
"parentUuid": "07976146_4c87bec5",
"revId": "88cc1a2dbad497c84f09ec3b513cdca57b314160",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}