cellular-infrastructure
/
mncc-python
mirror of https://gerrit.osmocom.org/mncc-python
9
0
Fork 0
Code Releases Activity

Update patch set 3 

Patch Set 3: Code-Review-1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1, 1815df7dc415322b44a238e156315b3eb63cdd45
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010 2024-03-17 08:16:16 +00:00 committed by Gerrit Code Review
parent b1e4988ccf
commit 8e34d20a1b
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
3b83fc87226dd7ee98542c55cff7ee5efa77b4bc Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "10277a07_86000a05",
"filename": "mncc_test.py",
"patchSetId": 3
},
"lineNbr": 72,
"author": {
"id": 1000010
},
"writtenOn": "2024-03-17T08:16:16Z",
"side": 1,
"message": "This is wrong, you need four more spaces. Otherwise the code below in unreachable.",
"range": {
"startLine": 72,
"startChar": 4,
"endLine": 72,
"endChar": 10
},
"revId": "3b83fc87226dd7ee98542c55cff7ee5efa77b4bc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "205ea397_4b12ed73",
"filename": "rtpsource/Makefile",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 1000010
},
"writtenOn": "2024-03-17T08:16:16Z",
"side": 1,
"message": "this looks unrelated to the py3 migration?",
"range": {
"startLine": 2,
"startChar": 12,
"endLine": 2,
"endChar": 17
},
"revId": "3b83fc87226dd7ee98542c55cff7ee5efa77b4bc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}