cellular-infrastructure
/
libgtpnl
mirror of https://gerrit.osmocom.org/libgtpnl
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000004 2023-10-15 12:18:50 +00:00 committed by Gerrit Code Review
parent 1f6909db1f
commit 9b4fbf56ea
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
7bc2c38d0964756f7450ac8e8d2f6627895f4e01
View File

@ -17,6 +17,24 @@
"revId": "7bc2c38d0964756f7450ac8e8d2f6627895f4e01",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "df2ba139_0260363b",
"filename": "include/linux/gtp.h",
"patchSetId": 1
},
"lineNbr": 27,
"author": {
"id": 1000004
},
"writtenOn": "2023-10-15T12:18:50Z",
"side": 1,
"message": "The kernel code used to call it GTPA_SGSN_ADDRESS initially at the time the kernel GTP only supported the \"GGSN role\". We later renamed it to the more generic PEER_ADDRESS when introducing support for SGSN role to kernel GTP.\n\nSee linux.git:\n\ncommit ae6336b57ede8cdf801b04e6d943617bb945e3f9\nAuthor: Jonas Bonn \u003cjonas@southpole.se\u003e\nDate: Fri Mar 24 23:23:20 2017 +0100\n\n gtp: rename SGSN netlink attribute\n\nWhich contains\n\n- GTPA_SGSN_ADDRESS,\n+ GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */\n+#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */\n\nI don\u0027t know why in libgtpnl we didn\u0027t introduce the compat #define in\n\ncommit 6e9afbbc3037c9e003260077b33dad202d5c55df\nAuthor: Jonas Bonn \u003cjonas@southpole.se\u003e\nDate: Fri Mar 24 15:19:19 2017 +0100\n\n-- in any case, I think we can continue to live without that #define in userspace, or we simply add it here to avoid any confusing diff to the kernel header file.",
"parentUuid": "909c69a6_2fe7781a",
"revId": "7bc2c38d0964756f7450ac8e8d2f6627895f4e01",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {