9
0
Fork 0

m2ua: Close a huge memory leak in the m2ua code.

This commit is contained in:
Holger Hans Peter Freyther 2011-02-15 16:51:43 +01:00
parent b187049925
commit 1927e638e1
1 changed files with 6 additions and 3 deletions

View File

@ -454,7 +454,7 @@ static int sctp_m2ua_write(struct mtp_link *link, struct msgb *msg)
trans = (struct mtp_m2ua_link *) link;
if (llist_empty(&trans->conns))
return -1;
goto clean;
llist_for_each_entry(tmp, &trans->conns, entry)
if (tmp->established && tmp->asp_active && tmp->asp_up) {
@ -464,12 +464,12 @@ static int sctp_m2ua_write(struct mtp_link *link, struct msgb *msg)
if (!conn) {
LOGP(DINP, LOGL_ERROR, "No active ASP?\n");
return -1;
goto clean;
}
m2ua = m2ua_msg_alloc();
if (!m2ua)
return -1;
goto clean;
mtp_handle_pcap(link, NET_OUT, msg->data, msg->len);
@ -487,6 +487,9 @@ static int sctp_m2ua_write(struct mtp_link *link, struct msgb *msg)
m2ua_conn_send(conn, m2ua, &info);
m2ua_msg_free(m2ua);
clean:
msgb_free(msg);
return 0;
}