86 lines
3.0 KiB
Plaintext
86 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "f618c2d8_0086b4fe",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2018-09-28T12:10:17Z",
|
|
"side": 1,
|
|
"message": "If the commit message states that we \"add module parameters\",\nit should add module parameters, but not L1CTL/L3 templates.\n\nA separate change makes sense I think ;)",
|
|
"revId": "d0247c4427f88289b5161ac6a4ab62cd400be9d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "b3b9aa9f_e84ca3e1",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2018-09-28T13:46:52Z",
|
|
"side": 1,
|
|
"message": "Agree",
|
|
"parentUuid": "f618c2d8_0086b4fe",
|
|
"revId": "d0247c4427f88289b5161ac6a4ab62cd400be9d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "40c69c3f_75e733c7",
|
|
"filename": "library/L1CTL_Types.ttcn",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 281,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2018-09-28T12:10:17Z",
|
|
"side": 1,
|
|
"message": "The L1CTL_DATA_REQ is not only used to carry SACCH messages.\nOther message types (non-SACCH) have no L1 SACCH header.\n\nIt should actually contain the \u0027l1ctl_info_ul\u0027 header,\nsee OsmocomBB/l1ctl_proto.h for details.\n\nAnyway, the L1CTL implementation should be abstracted\nfrom this. What about L3_Templates.ttcn?",
|
|
"range": {
|
|
"startLine": 281,
|
|
"startChar": 13,
|
|
"endLine": 281,
|
|
"endChar": 25
|
|
},
|
|
"revId": "d0247c4427f88289b5161ac6a4ab62cd400be9d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "91145057_6d13b658",
|
|
"filename": "library/L1CTL_Types.ttcn",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 281,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2018-09-28T13:46:52Z",
|
|
"side": 1,
|
|
"message": "That\u0027s why l1header is defined as optional. ts_L1CTL_DATA_REQ still uses \"octetstring other\", but could be changed to use L1ctlDataReq with l1header :\u003d omit.\n\nIt already contains the info_ul part, see ts_L1CTL_DATA_REQ and ts_L1CTL_DATA_REQ_SACCH.\n\nI\u0027ll look into adding it to L3_Templates. I added it here since it looked like the less aggressive change, and I couldn\u0027t find a real good place for it (since it\u0027s actually a L1 header, not l2 apparently.",
|
|
"parentUuid": "40c69c3f_75e733c7",
|
|
"range": {
|
|
"startLine": 281,
|
|
"startChar": 13,
|
|
"endLine": 281,
|
|
"endChar": 25
|
|
},
|
|
"revId": "d0247c4427f88289b5161ac6a4ab62cd400be9d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |