57 lines
1.9 KiB
Plaintext
57 lines
1.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "93d48e8f_489e1f3c",
|
|
"filename": "hnbgw/HNBGW_Tests.ttcn",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 414,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-01-26T13:16:26Z",
|
|
"side": 1,
|
|
"message": "Isn\u0027t this breaking existing tests which used test_CT HNBAP[i] ?",
|
|
"revId": "bbd5ad4ff4274e1fe88549177c6519800b151120",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "66df24a6_1f88e74c",
|
|
"filename": "hnbgw/HNBGW_Tests.ttcn",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 414,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-01-26T14:31:49Z",
|
|
"side": 1,
|
|
"message": "Usually you have the test logic either in the test_CT or in the ConnHdlr. Why would this break the test_CT ones? With this patch applied, the ConnHdlr spawned by this function gets exclusive access to one of the HNBAP ports (determined by pars.hnb_idx). Leaving an HNBAP port connected to the test_CT would require all HNBAP.send() operations to use explicit addressing...",
|
|
"parentUuid": "93d48e8f_489e1f3c",
|
|
"revId": "bbd5ad4ff4274e1fe88549177c6519800b151120",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e40bd8a6_a87f3ef3",
|
|
"filename": "hnbgw/HNBGW_Tests.ttcn",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 414,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-01-26T14:38:20Z",
|
|
"side": 1,
|
|
"message": "because there may be tests currently spawning ConHdlr but still sending HNBAP from the test_CT, that\u0027s why I\u0027m asking.",
|
|
"parentUuid": "66df24a6_1f88e74c",
|
|
"revId": "bbd5ad4ff4274e1fe88549177c6519800b151120",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |