osmo-ttcn3-hacks/549a1f370275fb617f2eb58ab68...

144 lines
4.4 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "fa87a4c6_ed625695",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 41,
"author": {
"id": 1000074
},
"writtenOn": "2024-04-02T15:35:51Z",
"side": 1,
"message": "I\u0027d prefer having this one prefixed \"f_ts_\", since it\u0027s actually a function.\nFurthermore, this is a ts_ template, so it makes no sense to receive a \"template charstring\". It should be at least \"template (omit) charstring\".",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "a703254b_c50d7499",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 41,
"author": {
"id": 1000028
},
"writtenOn": "2024-04-19T11:55:40Z",
"side": 1,
"message": "Done",
"parentUuid": "fa87a4c6_ed625695",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "c144563b_a13d3c6e",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 42,
"author": {
"id": 1000074
},
"writtenOn": "2024-04-02T15:35:51Z",
"side": 1,
"message": "template (omit) charstring",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "c033169a_48c0c19c",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 42,
"author": {
"id": 1000028
},
"writtenOn": "2024-04-19T11:55:40Z",
"side": 1,
"message": "Done",
"parentUuid": "c144563b_a13d3c6e",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "79f1158b_02fef378",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 1000074
},
"writtenOn": "2024-04-02T15:35:51Z",
"side": 1,
"message": "I\u0027m not sure ispresent() can be used this way, or only for optional fields in a record. You probably need \"istemplatekind\". Make sure ispresent() doesn\u0027t return always true here.",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "2752abad_bcf7364b",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 1000028
},
"writtenOn": "2024-04-19T11:55:40Z",
"side": 1,
"message": "I have verified that it works with ispresent(), but if (not istemplatekind(body, \"omit\")) also works.",
"parentUuid": "79f1158b_02fef378",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "0d028e9e_752b2958",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 59,
"author": {
"id": 1000074
},
"writtenOn": "2024-04-02T15:35:51Z",
"side": 1,
"message": "I think it makes sense to move this to a separate function \"merge_headers()\" or \"overlay_headers()\".\nThis way the test can also simply get the regular header and call that function.",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "05a2da73_5e253896",
"filename": "library/HTTP_Adapter.ttcn",
"patchSetId": 1
},
"lineNbr": 59,
"author": {
"id": 1000028
},
"writtenOn": "2024-04-19T11:55:40Z",
"side": 1,
"message": "Done",
"parentUuid": "0d028e9e_752b2958",
"revId": "549a1f370275fb617f2eb58ab68358e590e15661",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}