Commit Graph

3613 Commits

Author SHA1 Message Date
Neels Hofmeyr 9c83eeb438 msc: add MSC_Tests_Iu.control to MSC_Tests.cfg
Also run the Iu tests for osmo-msc.

Same as we have in docker-playground.git/ttcn3-msc-test/MSC_Tests.cfg

Related: SYS#5066
Change-Id: Ied0449fd0328ee57b66e3cff9d34b0e1d27b9fb4
2022-08-07 15:48:17 +02:00
Neels Hofmeyr 02d513efd8 msc: call: allow using MGW conn IPs in either order
So far, the first CRCX dispatched by osmo-msc is used for the RAN side,
and the second one for the CN side. Upcoming changes to osmo-msc move
the CN side CRCX to an earlier point in time, reversing that order.

Allow both RTP addresses from the two MGCP CRCX OK to appear in the
Assignment Request message to RAN, so that the test succeeds for both
the current osmo-msc and the upcoming patch (see below).

Related: SYS#5066
Related: Ie433db1ba0c46d4b97538a969233c155cefac21c (osmo-msc)
Change-Id: Id0c98bc267daff352fc7db7712f967111970fd4d
2022-08-07 15:48:17 +02:00
Pau Espin a8cc0d4db0 cbc: Add expected-results.xml
Change-Id: I9bf2c513a30c943bf87b47154a10147dc49c3d02
2022-08-05 22:31:33 +02:00
Pau Espin e71951343f cbc: Introduce test TC_cell_failure_restart_active_{cbc,mme}
These tests are currently failing since osmo-cbc doesn't support
reloading cells yet.

Related: OS#5641
Change-Id: I7b1c5275eff56888268601b481e8f8c1dd1bb1b0
2022-08-05 22:31:33 +02:00
Pau Espin 45ef775232 cbc: Introduce test TC_cell_failure_restart_idle_mme
Related: OS#4945
Change-Id: Ie0ab3d4fbe1d9a824b1f69ceacbf7dfd4f0d9728
2022-08-05 22:31:33 +02:00
Pau Espin 715d678033 cbc: Introduce test TC_cell_failure_restart_idle_bsc
Change-Id: Ia868bf739c29d5b4548bbd1417c352ee6400f501
2022-08-05 22:31:33 +02:00
Pau Espin 9c979d5397 cbc: BCS_ConnHdlr: avoid handling received RESTART messages
CBSP RESTART messages are only sen BSC->CBS direction, so it makes no
sense to activate the receival of RESTART messages in the BSC emulation.

Change-Id: I40e78ff4d980050a6142226a7eb9589f2d15e5bd
2022-08-05 22:31:33 +02:00
Pau Espin 6b3e8e34c4 cbc: Introduce test TC_create_nack_mme
Related: OS#4945
Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36
2022-08-05 22:31:26 +02:00
Pau Espin 6dd5a0f829 cbc: Introduce test TC_create_nack_bsc
Related: OS#4945
Change-Id: Iabeb3e9d86eaf59b76504edf3976a947ae29b911
2022-08-05 22:30:37 +02:00
Pau Espin 910ef1c74b sbcap: Add missing cause types
Change-Id: I09526f5ac19c80927b6b8ad1cff874a86e0b3a04
2022-08-05 20:29:24 +00:00
Pau Espin 855c56c446 cbc: remove unneded template local var
Change-Id: I31f751f5c61de545d038d9e63e01188c3ae5f161
2022-08-05 20:29:24 +00:00
Pau Espin 8c67433741 sbcap: Fix spec references in comments
Change-Id: I89bc9d15548e6c709f0e1b614f00bc98ec41d441
2022-08-05 20:29:24 +00:00
Pau Espin e7d3d99293 cbc: Test ETWS msg over SBc-AP
So far only non-emergency CBS messages were tested, which require a
slighlty idfferent encoding on the protocol side.

Related: OS#4945
Change-Id: I506322fc8a664716db8cd79217c2091b0b926836
2022-08-05 20:29:24 +00:00
Pau Espin ad5d2dbd47 cbc: Test ETWS msg over CBSP
So far only non-emergency CBS messages were tested, which require a
slighlty idfferent encoding on the protocol side.

Related: OS#4945
Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de
2022-08-05 20:29:24 +00:00
Vadim Yanitskiy c5fcb89b8d MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest
According to [1], 3GPP TS 48.008 does indicate that on AoIP the MSC
Preferred Codec List IE shall be present in BSSMAP HandoverRequest.
Let's verify that the IUT actually includes this IE.

Change-Id: I2e0ecbcced9f94d2b44d981db353007cad3ae959
Related: osmo-bsc.git I117cc29d6d11db77d160de654f43f5993db6ee21
Related: OS#5529
2022-08-05 17:38:43 +00:00
Vadim Yanitskiy 6fe5d4e33e BSSMAP_Templates: add SpeechCodecList param to tr_BSSMAP_HandoverRequest
Change-Id: Ia5ce0c03fd4198e26068ddd1f18f2e17b1ae533d
Related: OS#5529
2022-08-05 17:38:43 +00:00
Vadim Yanitskiy 3999491614 BTS_Tests: send SACCH blocks in TC_rsl_ms_pwr_dyn_{up,max,ass_updown}
We used to rely on trxcon sendig dummy RR Measurement Reports and
patching the L1 SACCH Header with the configured MS Power Level
and Timing Advance values.  Since recently, the following testcases
started to fail because trxcon does not patch dummy MRs anymore:

* TC_rsl_ms_pwr_dyn_ass_updown,
* TC_rsl_ms_pwr_dyn_max, and
* TC_rsl_ms_pwr_dyn_up.

Do not rely on dummy MRs, send SACCH blocks with the expected
MS Power Level and Timing Advance values from the testsuites.

f_send_meas_rep() internally uses:

* g_pars.l1_pars.ms_power_level, and
* g_pars.l1_pars.ms_actual_ta.

Change-Id: I31dd6b9026d04403092256176f67785a0a6486ad
Related: OS#5635
2022-08-05 13:11:31 +00:00
Vadim Yanitskiy 9dd880f508 BTS_Tests: separate f_send_meas_rep() from f_transceive_meas_rep()
The key difference is that f_send_meas_rep() simply sends an RR
Measurement Report and does not wait until it's received on the RSL.

Change-Id: Ia5d0315e053702df5fa8dad8c6c66c11c9f3edcb
2022-08-05 13:10:20 +00:00
Pau Espin a5536b697d cbc: test concurrent CBS message
Test having more than one active CBS message being broadcasted to an
MME.

Related: OS#4945
Change-Id: Ie9208c33f3b2586e19b446318b6ae9da07a76506
2022-08-04 13:32:39 +02:00
Pau Espin 74f62981a8 cbc: Expect Concurrent-Warning-Message-Indicator IE in SBcAP Write-Repl-Req
3GPP TS 23.041 9.3.32 states that the IE is always present for non-ETWS
messages and never present in ETWS messages.
The present template is used for CBS messages (non-ETWS) only so far.
Once we add support to test ETWS message this will be updated
accordingly if needed.

Related: osmo-cbc.git I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef
Related: OS#4945
Change-Id: I8f2067069ecf0c46f86279413a10e5970ec4456c
2022-08-04 13:32:39 +02:00
Pau Espin b1a83fbb6d cbc: Test sending Unknown TAI List to osmo-cbc
Related: OS#4945
Change-Id: I7d8cf5e6498d03ad340b8f843ce93a20171e9fca
2022-08-04 13:32:32 +02:00
Pau Espin db247f8318 cbc: Support mme/bsc sctp/tcp server mode
Related: OS#4945
Change-Id: I9fa4ddfa18ac85644f219874e6b2166e1795e3a9
2022-08-02 11:50:54 +02:00
Pau Espin 7e45128ec0 cbc: Add Tguard
Change-Id: I92b0a2ec931cefed34a33bd90cbc5c97d0aec540
2022-08-02 08:37:16 +00:00
Pau Espin ae2e51557f cbc: Send Write-Replace-Warn-Ind after ACKing the request
This way we can test how does osmo-cbc behave when receiving such
message.

Related: OS#4945
Change-Id: Ifcdcddc7dccb5439126a5fa29bb540669ed25908
2022-08-02 08:37:16 +00:00
Pau Espin e14c2087cf cbc: Change default cbsp/sbcap ports to allow multiple bsc/mme
The BSC/MMEs ports are applied in osmo-cbc.cfg similarly in sequential
order.

Change-Id: Ib443aba9396aebe0a56b1a79719bbcf66302a1aa
2022-08-02 08:37:16 +00:00
Pau Espin 1976346cb7 cbc: Enable MMEs and BSCs selectively
Let's only create BSC handlers (no MM handlers) in tests validating CBSP
specific features.
A new test is added to specifically validate scenarios with both an MME
and BSC attached to the CBC.

Change-Id: I79ee41f183ef49e9fd606d2a3efa2767628bf142
2022-08-02 08:37:16 +00:00
Vadim Yanitskiy c78aeb7cc6 BTS_Tests: increate Tguard to 30.0s for TC_rsl_ms_pwr_dyn_up
A comment in f_TC_rsl_ms_pwr_dyn_up() states:

> By default, the MS power loop gets triggered every 4th SACCH block (1.92s).
> We need 9 * 4 dB steps to get from 0 dBm to 33 dBm, so 9 * 1.92s total.
> Add an extra offset to avoid race conditions: +1.92s.

so the alt statement is expected to block for 19.2s, while the guard
timer is set to 20.0s by default.  This is not enough, given that
f_TC_rsl_ms_pwr_dyn_up() also needs to wait for the first SACCH block
before entering the alt statement.

Let's give it more time to run in order to avoid sporadic failures.

Change-Id: Ib7de8383c95ac9e00560f786ec4c56f79f7d81bc
Related: OS#5635
2022-08-01 12:37:19 +00:00
Vadim Yanitskiy e3351bb2ad BTS_Tests: tune back to CCCH/BCCH in TC_sacch_chan_act_ho_[a]sync
Sending L1CTL_DM_REL_REQ does not make the L1 tune back to CCCH/BCCH.
We need to send a L1CTL_FBSB_REQ after releasing a dedicated channel
if we want to establish another one.  This is essential when running
tests using Calypso PHY, and will be required once we have proper
trxcon_fsm implementation [1] merged.

Related: [1] osmocom-bb.git Ifaf63ead9dd180181358e771367b2a686ba159ca
Change-Id: I65fb243a62fc7670b43f467d6b79268cdfb98f36
2022-08-01 12:37:19 +00:00
Vadim Yanitskiy 2534135632 BTS_Tests: f_est_rll_mo(): add waiting timeout (2s)
This helps to find where the problem is a lot quicker.

Change-Id: I71ab69d85f453964749270d970c55e6f577a73a1
2022-08-01 12:37:19 +00:00
Vadim Yanitskiy 68c4cff30e library/GSM_RR_Types: make ts_SacchL1Header easier to use
Move parameter 'fpc' at the end and assign false by default, so that
there is not need to pass false.  We never set it to true anyway.

Change-Id: I8a0ef562c2426a637fbb9fe3d50711ee7738d04f
2022-08-01 12:37:19 +00:00
Pau Espin 3dfa807769 cbc: Fix use of incorrect variable in loop
This went unnoticed before because all tests were running with both bsc
and mme set to 1.

Change-Id: I978c92819cb4e218c95bc719ade71787dc474b23
2022-07-29 16:29:55 +02:00
Pau Espin 4ff118a230 cbc: Handle each CBSP and SBc-AP on a separate component
* Each BSC_ConnectionHandler emulates a BSC and handles one TCP/CBSP
  conn.
* Each MME_ConectionHandler emulates an MME and handles one SCTP/SBc-AP
  conn.
* ECBE related functionalities are moved to its own file
  ECBE_Components.ttcn.
* CBS_Message is moved to its own file since it is used by all modules.

Related: OS#4945
Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
2022-07-29 13:04:36 +00:00
Pau Espin 78d80e7469 sbcap: Expect IE Send-Write-Replace-Warning-Indication
Since osmo-cbc.git I563e7d1c999f14b8197bb41e85b7bcf6262fe2a0, Write
Replace Warning Indication is sent, so expect it.

Change-Id: I84e3ae7a532a8a76ac1c26d357da7eaa73f39374
2022-07-28 12:39:39 +02:00
Pau Espin e736981121 cbc: Fix f_sbcap_tx_write_replace_warn_resp()
The line was wrongly removed when pushing a new version of the patch for
review submission.

Fixes: 7c13cb7e0f
Change-Id: If99ff5b83e8f0c577e60e0406b001a3753213deb
2022-07-20 18:17:05 +02:00
Pau Espin 7c13cb7e0f Support for SBc-AP protocol as used on the MME-CBC interface
This requires a recent libfftranscode (>=0.5) with SBC-AP support.

The asn files are obtained from 3GPP TS 29.168.

Related: osmo-cbc.git Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Related: docker-playground.git 5f3c78105836d1f2c229655df3f537a73ab6e12a
Change-Id: Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2
Related: OS#4945
2022-07-18 11:20:14 +02:00
Oliver Smith bf458d5f9f checkpatch.conf: ignore imported sbcap *.asn files
Prepare to import files to library/sbcap, which we don't want to be
linted in Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2.

Change-Id: I3ab3253753d32a266bdaf32fb247c2c0139d40d3
2022-07-18 08:56:46 +00:00
Pau Espin 528f5affda bsc: cbsp: Expect one Reset/Failure Ind for each Bcast Msg Type
As described in 3GPP TS 48.049:

7.8.2: "The RESTART message is sent once per broadcast message type as
 indicated by the Broadcast Message Type IE."
7.9.2: "The FAILURE message is sent once per broadcast message type as
 indicated by the Broadcast Message Type IE."

Related: osmo-bsc.git Change-Id I6668b55868cf534a3b59da5e11542abb8131d604
Related: SYS#5910
Change-Id: I05da2f61d26a1124d30793184d81aabf212cddda
2022-07-15 14:51:48 +02:00
Pau Espin 696fbe75a2 bsc_cbsp: Support receiving CGI as cellID in CBSP Reset and Failure Ind
New versions of osmo-bsc send CGI instead of LAC+CI, which provides more
information (PLMN).

Related: SYS#5910
Change-Id: I48e86150f499f0f458f75f132087319d80f86448
2022-07-15 14:51:43 +02:00
Philipp Maier 13aff99872 MGCP_Test: add testcase TC_e1_dlcx_wildcarded
We are currently testing the behaviour of wildcarded DLCX on the virtual
trunk. Lets run a similar test on the E1 trunk as well.

Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc
Related: OS#5572
2022-07-11 19:14:59 +00:00
Philipp Maier 6c740e8d52 MGCP_Test: fix TC_dlcx_wildcarded
When the final condition of the testcase is verified through statsd,
there may be still (invalid) data from a previous measurement in the
statsd pipeline, querying the stats once before verifying the actual
stats fixes the problem.

Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3
Related: OS#5572
2022-07-11 19:14:59 +00:00
Pau Espin ac71dbb1e5 cbc: Refactor and split f_cbsp_write()
Change-Id: I827fad869c6ca5ce80dd39d30c2e3393b2394217
2022-07-08 17:14:45 +02:00
Vadim Yanitskiy 52aee747b4 BSC_Tests_CBSP: fix f_exp_rsl_etws(): add some guard time
Recently I noticed sporadic CBSP test case failures on Jenkins:

  Timeout waiting for RSL_OSMO_ETWS_CMD (disable)
    BSC_Tests_CBSP.ttcn:1209 BSC_Tests_CBSP control part
    BSC_Tests_CBSP.ttcn:1056 TC_cbsp_emerg_write_bts_cgi_cchan_disable

The related timeout is set to 5.0 seconds in f_exp_rsl_etws(), what
matches the Warning Period IE sent in CBSP WRITE-REPLACE message.

Adding a debug log printing T.read on receipt of RSL_OSMO_ETWS_CMD
reveals that we're cutting it too close: the message arrives just
a few milliseconds before the timeout expires.

  f_exp_rsl_etws(): T := 4.999196s, remaining 0.000804s
  f_exp_rsl_etws(): T := 4.998683s, remaining 0.001317s
  f_exp_rsl_etws(): T := 4.999344s, remaining 0.000656s

Let's increase the timeout value (+0.5s) to avoid sporadic failures.

Change-Id: Ia40a268f9780ffbcfa2bb962d7c1ac25d16193de
2022-06-28 23:40:36 +07:00
Vadim Yanitskiy d3bef0a0a0 BSC_Tests_CBSP: cosmetic: move T.start closer to the alt statement
Change-Id: Ib84fadad77b908f0bb71d6fdefda2513ee510ce1
2022-06-28 23:16:07 +07:00
Vadim Yanitskiy 87ebd0bd16 library/MGCP_Templates: add send template ts_MgcpResp_Err
Change-Id: Ib0462228cece29952c91b4d18ebe2d89fed70c03
Related: OS#5572
2022-06-28 03:58:38 +07:00
Pau Espin d5496adfdb bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
This should avoid some sporadic failure sptted during tear down.

Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe
2022-06-23 18:47:31 +07:00
Vadim Yanitskiy 65d879d957 bsc: release dchan in TC_cbsp_emerg_write_bts_cgi_dchan
A follow-up patch is adding BSC_Tests.f_shutdown_helper() calls to all
CBSP testcases, what makes TC_cbsp_emerg_write_bts_cgi_dchan fail due
to talloc count mismatch.  All dchans need to be released to avoid this.

Change-Id: I8b707c821693f930ab10bd8feea08ba5007da967
2022-06-23 18:47:31 +07:00
Vadim Yanitskiy 5eb06a3865 bsc: make BSC_Tests_CBSP module a friend of BSC_Tests
This allows BSC_Tests_CBSP to import friendly API from BSC_Tests.
The line importing stuff from BSC_Tests BSC_Tests_CBSP.ttcn is moved
on top for consistency with an existing friend - BSC_Tests_VAMOS.

Change-Id: Ie0bb5c2e33aadd4858f0f6d001468985c40ab152
2022-06-23 18:47:26 +07:00
Pau Espin 9d8b6bf717 cbc: Introduce f_shutdown_helper() and call it in every test
Change-Id: I95e6f8a5a5c35d35662950e1105bdb17d2ca00de
2022-06-23 18:34:27 +07:00
Pau Espin 51dca9fa15 ggsn,pgw: Expect Multiple-Services-Indicator AVP in Initial CCR
Multiple-Services-Indicator AVP is only meant to be sent in CCR Init.
Let's not expect it in Update nor in Termination CCR, open5gs stopped
sending it there recently in 9948fba05afb8e1b118f0c29a84ffe38c0f21b75.

Change-Id: Ic4d6be4bf28c65817ce912a8be10937db0b5dba9
2022-06-21 17:07:20 +02:00
Pau Espin 07746ad99e cbc: Improve CBSP port configuration
Previous -1 was taken by TTCN3 as default port (9999). Let's keep it
excplictly as 9999 by default to avoid changing docker-playground.git.

Change-Id: Ia7c599faa2101180089085c6cf5d483d2325ecac
2022-06-17 20:28:22 +00:00