From e46ebe070c3853e707f4a9507506783fe29a4d97 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326> Date: Thu, 26 Jan 2023 14:31:49 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: Code-Review+1 (1 comment) Patch-set: 1 Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"fixeria replied on the change"} --- bbd5ad4ff4274e1fe88549177c6519800b151120 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/bbd5ad4ff4274e1fe88549177c6519800b151120 b/bbd5ad4ff4274e1fe88549177c6519800b151120 index 975e1ebcd..6337ad1ab 100644 --- a/bbd5ad4ff4274e1fe88549177c6519800b151120 +++ b/bbd5ad4ff4274e1fe88549177c6519800b151120 @@ -16,6 +16,24 @@ "message": "Isn\u0027t this breaking existing tests which used test_CT HNBAP[i] ?", "revId": "bbd5ad4ff4274e1fe88549177c6519800b151120", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "66df24a6_1f88e74c", + "filename": "hnbgw/HNBGW_Tests.ttcn", + "patchSetId": 1 + }, + "lineNbr": 414, + "author": { + "id": 1000010 + }, + "writtenOn": "2023-01-26T14:31:49Z", + "side": 1, + "message": "Usually you have the test logic either in the test_CT or in the ConnHdlr. Why would this break the test_CT ones? With this patch applied, the ConnHdlr spawned by this function gets exclusive access to one of the HNBAP ports (determined by pars.hnb_idx). Leaving an HNBAP port connected to the test_CT would require all HNBAP.send() operations to use explicit addressing...", + "parentUuid": "93d48e8f_489e1f3c", + "revId": "bbd5ad4ff4274e1fe88549177c6519800b151120", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file