ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"fixeria replied on the change"}
This commit is contained in:
Gerrit User 1000010 2023-01-26 14:31:49 +00:00 committed by Gerrit Code Review
parent 8be204ad4b
commit e46ebe070c
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
bbd5ad4ff4274e1fe88549177c6519800b151120
View File

@ -16,6 +16,24 @@
"message": "Isn\u0027t this breaking existing tests which used test_CT HNBAP[i] ?",
"revId": "bbd5ad4ff4274e1fe88549177c6519800b151120",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "66df24a6_1f88e74c",
"filename": "hnbgw/HNBGW_Tests.ttcn",
"patchSetId": 1
},
"lineNbr": 414,
"author": {
"id": 1000010
},
"writtenOn": "2023-01-26T14:31:49Z",
"side": 1,
"message": "Usually you have the test logic either in the test_CT or in the ConnHdlr. Why would this break the test_CT ones? With this patch applied, the ConnHdlr spawned by this function gets exclusive access to one of the HNBAP ports (determined by pars.hnb_idx). Leaving an HNBAP port connected to the test_CT would require all HNBAP.send() operations to use explicit addressing...",
"parentUuid": "93d48e8f_489e1f3c",
"revId": "bbd5ad4ff4274e1fe88549177c6519800b151120",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}