ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

RTP_Emulation: Avoid failure if T_transmit triggers between bind and connect 

During MGCP_Test's f_flow_modify, an RTP socket may be Tx-enabled, and
f_flow_modify first calls bind, then connect, with MDCX transaction in
the middle (which can take some time).

If T_transmit from RTP_Emulation triggers (RTP packet to be send),
during that time, TTCN3 will fail to send the packet:
RTP_Emulation.ttcn:312 Message enqueued on RTP from system @Socket_API_Definitions.PortEvent : { result := { errorCode := ERROR_SOCKET (4), connId := 2, os_error_code := 89, os_error_text := "Destination address required" } } id 1

Change-Id: I20e7aed35bb28200e30ee5efc718f77e036d8262
This commit is contained in:
Pau Espin 2019-05-17 18:40:43 +02:00 committed by Harald Welte
parent 8b01c794f0
commit e38bfe0683
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
library/RTP_Emulation.ttcn
View File

@ -85,6 +85,7 @@ type component RTP_Emulation_CT {
/* state variables, change over time */
var boolean g_rx_enabled := false;
var boolean g_tx_connected := false; /* Set to true after connect() */
var LIN2_BO_LAST g_tx_next_seq := 0;
var uint32_t g_tx_next_ts := 0;
@ -347,6 +348,8 @@ function f_main() runs on RTP_Emulation_CT
log("Local Port is not an even port number!");
continue;
}
g_tx_connected := false; /* will set it back to true upon next connect() call */
res := RTP_CodecPort_CtrlFunct.f_IPL4_listen(RTP, g_local_host,
g_local_port, {udp:={}});
if (not ispresent(res.connId)) {
@ -387,6 +390,7 @@ function f_main() runs on RTP_Emulation_CT
setverdict(fail, "Could not connect to RTCP socket, check your configuration");
mtc.stop;
}
g_tx_connected := true;
CTRL.reply(RTPEM_connect:{g_remote_host, g_remote_port});
}
[] CTRL.getcall(RTPEM_mode:{RTPEM_MODE_NONE}) {
@ -466,7 +470,7 @@ function f_main() runs on RTP_Emulation_CT
}
/* transmit if timer has expired */
[] T_transmit.timeout {
[g_tx_connected] T_transmit.timeout {
/* send one RTP frame, re-start timer */
f_tx_rtp(g_cfg.tx_fixed_payload);
T_transmit.start;