ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

Revert "bts: f_init_pcu: sleep before connect" 

This reverts commit c089b415f5. The
additional sleep caused other tests to break, probably because it
triggered race conditions:
* TC_pcu_socket_connect_multi
* TC_pcu_socket_connect_si3gprs
* TC_si_sched_13_2bis_2ter_2quater

Adjust TC_pcu_socket_verify_info_ind test case error message to mention
OS#4179. This test is flapping now, most of the time the BTS sends a
CellID 0 because it did not receive the real CellID from the BSC yet.

Related: OS#4179
Change-Id: I2115c337f4601a4614b140715323c42803b003ee
This commit is contained in:
Oliver Smith 2019-09-04 11:35:56 +02:00 committed by osmith
parent 1f4486cfe3
commit e1c00f022d
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bts/BTS_Tests.ttcn
View File

@ -324,9 +324,6 @@ private function f_init_pcu(PCUIF_CODEC_PT pt, charstring id,
pcu_conn_id := -1;
return;
}
f_sleep(0.5); /* workaround for OS#4179 */
pcu_conn_id := f_pcuif_connect(pt, mp_pcu_socket);
T.start;
@ -4876,7 +4873,9 @@ testcase TC_pcu_socket_verify_info_ind() runs on test_CT {
var uint16_t cell_id_si3 := si3.payload.si3.cell_id;
var uint16_t cell_id_pcu := g_pcu_last_info.u.info_ind.cell_id;
if (cell_id_si3 != cell_id_pcu) {
setverdict(fail, "Expected cell_id ", cell_id_si3, " got: ", cell_id_pcu);
setverdict(fail, "Expected cell_id '", cell_id_si3, "' and got '", cell_id_pcu, "'. This either means,",
" that the BTS is sending the wrong cell_id, or that the BTS sent it too early",
" (OS#4179)");
}
/* Verify LAC */