ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

sccp: Add TC_callingparty_ssn_only() 

This test verifies that libosmo-sccp will properly respond to SCCP
traffic that only has a SSN in the CallingPartyAddress.  That situation
poses the unique challenge of how to route a response, as we lack
a GT and a PC to do the routing.

In order to support this, libosm-sccp now adds the PC into the
CallingPartyAddr when passing such messages from M3UA to SCCP. This
way the recipient can simply respond back to that address and it will
be routed on PC.

Change-Id: Ided599a922fb7f6dbbfe90f817c5419ab793f293
Related: OS#5146
This commit is contained in:
Harald Welte 2021-05-13 21:54:58 +02:00
parent 2eb30d4eb7
commit aed9f94db4
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
library/SCCP_Templates.ttcn
View File

@ -15,6 +15,19 @@ import from SCCP_Types all;
import from SCCPasp_Types all;
import from SCCP_Emulation all;
/* construct a SCCP_PAR_Address with just SSN and no PC or GT */
template (value) SCCP_PAR_Address ts_SccpAddr_SSN(integer ssn) := {
addressIndicator := {
pointCodeIndic := '0'B,
ssnIndicator := '1'B,
globalTitleIndic := '0000'B,
routingIndicator := '1'B
},
signPointCode := omit,
subsystemNumber := ssn,
globalTitle := omit
}
/* construct a SCCP_PAR_Address with just PC + SSN and no GT */
template (value) SCCP_PAR_Address ts_SccpAddr_PC_SSN(integer pc, integer ssn, octetstring sio,
charstring sccp_srv_type) := {

24
sccp/SCCP_Tests_RAW.ttcn
View File

@ -312,7 +312,8 @@ testcase TC_it_avoids_tiar() runs on SCCP_Test_RAW_CT {
function f_scmg_xceive(SCCP_PAR_Address calling, SCCP_PAR_Address called,
template (value) PDU_SCMG_message tx,
template (omit) PDU_SCMG_message rx_exp) runs on SCCP_Test_RAW_CT
template (omit) PDU_SCMG_message rx_exp,
boolean accept_other_called_resp := false) runs on SCCP_Test_RAW_CT
{
var boolean exp_something := true;
timer T := 5.0;
@ -328,6 +329,9 @@ function f_scmg_xceive(SCCP_PAR_Address calling, SCCP_PAR_Address called,
[exp_something] MTP3.receive(tr_SCCP_MTP3_TRANSFERind(tr_SCCP_UDT(called, calling, decmatch rx_exp))) {
setverdict(pass);
}
[exp_something and accept_other_called_resp] MTP3.receive(tr_SCCP_MTP3_TRANSFERind(tr_SCCP_UDT(called, ?, decmatch rx_exp))) {
setverdict(pass);
}
[] MTP3.receive(tr_SCCP_MTP3_TRANSFERind(tr_SCCP_UDT(called, calling, ?))) {
setverdict(fail, "Received unexpected SCCP waiting for ", rx_exp);
}
@ -402,6 +406,22 @@ testcase TC_scmg_sst_ssn_invalid() runs on SCCP_Test_RAW_CT {
f_scmg_xceive(calling, called, tx, rx_exp);
}
/* Test CallingParty(only SSN) solicits response (OS#5146) */
testcase TC_callingparty_ssn_only() runs on SCCP_Test_RAW_CT {
var SCCP_PAR_Address calling, called;
var template (value) PDU_SCMG_message tx;
var template (present) PDU_SCMG_message rx_exp;
f_init_raw(mp_sccp_cfg[0]);
f_sleep(1.0);
called := valueof(ts_SccpAddr_SSN(1));
calling := valueof(ts_SccpAddr_SSN(1));
tx := ts_SCMG_SST(1, mp_sccp_cfg[0].peer_pc);
rx_exp := ts_SCMG_SSA(1, mp_sccp_cfg[0].peer_pc);
f_scmg_xceive(calling, called, tx, rx_exp, accept_other_called_resp:=true);
}
control {
@ -413,6 +433,8 @@ control {
execute( TC_scmg_sst_ssn1() );
execute( TC_scmg_sst_ssn_valid() );
execute( TC_scmg_sst_ssn_invalid() );
execute( TC_callingparty_ssn_only() );
}