bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear()

While osmo-bsc was still affected of OS#3331, it would release the SCCP
connection from the BSC side.  This is illegal as per 3GPP spec and
has meanwhile been fixed in osmo-bsc master.  However, the testcase
BSC_Tests_LCLS.TC_lcls_connect_clear() relied on the broken behavior,
let's fix that.

The testcase now releases the SCCP connection from the simulated MSC
side in response to the BSSMAP Clear Complete from the BSC.

Change-Id: Ic3e1f8729a093b04941ec7ca72664d53adb21229
This commit is contained in:
Harald Welte 2018-06-11 15:20:39 +02:00
parent e8d750e668
commit 935fbe336a
1 changed files with 4 additions and 2 deletions

View File

@ -116,6 +116,7 @@ private altstep as_lcls_conn_hdlr_proxy() runs on LCLS_MSC_ConnHdlr {
[] RSL.receive(RSL_Message:?) -> value rsl_msg { MASTER.send(rsl_msg); }
/* from master process to ConnHdlr */
[] MASTER.receive(PDU_BSSAP:?) -> value bssap { BSSAP.send(bssap); }
[] MASTER.receive(BSSAP_Conn_Prim:?) -> value bssap_p { BSSAP.send(bssap_p); }
[] MASTER.receive(PDU_DTAP_MO:?) -> value dtap_mo { BSSAP.send(dtap_mo); }
[] MASTER.receive(PDU_DTAP_MT:?) -> value dtap_mt { BSSAP.send(dtap_mt); }
[] MASTER.receive(MgcpCommand:?) -> value mgcp_cmd { MGCP.send(mgcp_cmd); }
@ -553,8 +554,9 @@ testcase TC_lcls_connect_clear() runs on lcls_test_CT {
f_rsl_find_ie(rsl, RSL_IE_CHAN_NR, ieb);
CONN_A.send(ts_RSL_RF_CHAN_REL_ACK(ieb.chan_nr));
}
[] CONN_A.receive(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_IND);
[] CONN_A.receive(tr_BSSMAP_ClearComplete);
[] CONN_A.receive(tr_BSSMAP_ClearComplete) {
CONN_A.send(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);
}
[] CONN_B.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_possible_ls));
}
f_sleep(2.0);