ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

bsc: add TC_ho_into_this_bsc_a5_mismatch 

Since I just fixed the encryption behavior, I also want to know whether
the case of no A5 intersection is handled properly.

The tiny test comes with a lot of changes to allow a handover failure
code path. The 'expect_ho_fail' flag goes via function arguments to
g_pars and the general ho test code uses it to branch for exp-failure.

Related: SYS#5839
Change-Id: I44b464a0bedbff09c467c4bccd7c985480fb883a
This commit is contained in:
Neels Hofmeyr 2022-02-17 21:58:47 +01:00
parent 46e16e50ab
commit 907b23b93a
2 changed files with 58 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
bsc/BSC_Tests.ttcn
View File

@ -5993,6 +5993,7 @@ testcase TC_ho_out_fail_no_result_after_ho_cmd() runs on test_CT {
}
private function f_ho_into_this_bsc(charstring id, template (omit) BSSMAP_oldToNewBSSIEs oldToNewBSSIEs := omit) runs on MSC_ConnHdlr {
var PDU_BSSAP rx_bssap;
/* Hack: the proper way would be to wait for the BSSMAP Handover Request ACK and extract the
* actual assigned chan_nr from its L3 (RR Handover Command) message. But osmo-bsc starts acting
* on the lchan even before we get a chance to evaluate the BSSMAP Handover Request ACK. So we
@ -6015,13 +6016,28 @@ private function f_ho_into_this_bsc(charstring id, template (omit) BSSMAP_oldToN
enc := g_pars.encr)));
BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_CONF_IND);
alt {
[] BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap {
if (g_pars.expect_ho_fail) {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
"Expected Handover Request to fail, but got Handover Request Ack")
}
}
[] BSSAP.receive(tr_BSSMAP_HandoverFailure) -> value rx_bssap {
if (not g_pars.expect_ho_fail) {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
"Expected Handover Request to succeed, but got Handover Failure")
}
// TODO: evaluate correct cause value. But osmo-bsc doesn't seem to send meaningful causes yet!
// For now just accept any cause.
BSSAP.receive(tr_BSSMAP_ClearRequest);
setverdict(pass);
return;
}
}
/* The RSL Emulation magically accepts the Chan Activ behind the scenes. */
var PDU_BSSAP rx_bssap;
var octetstring ho_command_str;
BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap;
/* we're sure that the channel activation is done now, verify the parameters in it */
var RSL_Message chan_act := f_rslem_get_last_act(RSL_PROC, 0, g_chan_nr);
f_verify_encr_info(chan_act);
@ -6053,6 +6069,7 @@ private function f_ho_into_this_bsc(charstring id, template (omit) BSSMAP_oldToN
}
}
var octetstring ho_command_str;
ho_command_str := rx_bssap.pdu.bssmap.handoverRequestAck.layer3Information.layer3info;
log("Received L3 Info in HO Request Ack: ", ho_command_str);
var PDU_ML3_NW_MS ho_command := dec_PDU_ML3_NW_MS(ho_command_str);
@ -6112,7 +6129,11 @@ private function f_tc_ho_into_this_bsc(charstring id) runs on MSC_ConnHdlr {
exp_rr_rel_tmpl := tr_RRM_RR_RELEASE;
}
f_ho_into_this_bsc(id, oldToNewBSSIEs);
f_perform_clear(exp_rr_rel_tmpl := exp_rr_rel_tmpl);
if (g_pars.expect_ho_fail) {
f_perform_clear_no_lchan();
} else {
f_perform_clear(exp_rr_rel_tmpl := exp_rr_rel_tmpl);
}
setverdict(pass);
}
function f_tc_ho_into_this_bsc_main(TestHdlrParams pars, charstring vty_a5_cfg := VTY_A5_DEFAULT) runs on test_CT {
@ -6131,9 +6152,14 @@ function f_tc_ho_into_this_bsc_main(TestHdlrParams pars, charstring vty_a5_cfg :
vc_conn.done;
f_ctrs_bsc_and_bts_add(0, "handover:attempted");
f_ctrs_bsc_and_bts_add(0, "handover:completed");
f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:attempted");
f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:completed");
if (pars.expect_ho_fail) {
f_ctrs_bsc_and_bts_add(0, "handover:failed");
f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:failed");
} else {
f_ctrs_bsc_and_bts_add(0, "handover:completed");
f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:completed");
}
f_ctrs_bsc_and_bts_verify();
f_vty_encryption_a5_reset();
@ -6145,9 +6171,11 @@ testcase TC_ho_into_this_bsc() runs on test_CT {
f_shutdown_helper();
}
function f_tc_ho_into_this_bsc_a5(TestHdlrEncrParams encr, charstring vty_a5_cfg := VTY_A5_DEFAULT) runs on test_CT {
function f_tc_ho_into_this_bsc_a5(TestHdlrEncrParams encr, charstring vty_a5_cfg := VTY_A5_DEFAULT,
boolean expect_fail := false) runs on test_CT {
var TestHdlrParams pars := f_gen_test_hdlr_pars();
pars.encr := encr;
pars.expect_ho_fail := expect_fail;
f_tc_ho_into_this_bsc_main(pars, vty_a5_cfg);
f_shutdown_helper();
}
@ -6184,6 +6212,12 @@ testcase TC_ho_into_this_bsc_a5_1_3() runs on test_CT {
f_tc_ho_into_this_bsc_a5(f_encr_params(alg_permitted := '0a'O, alg_expect := '08'O));
}
/* Send a permitted algo mask that does not intersect with osmo-bsc.cfg */
testcase TC_ho_into_this_bsc_a5_mismatch() runs on test_CT {
f_tc_ho_into_this_bsc_a5(f_encr_params(alg_permitted := '18'O, alg_expect := '10'O), "0 1",
expect_fail := true); // 0x18 = A5/3 and A5/4
}
testcase TC_ho_into_this_bsc_tla_v6() runs on test_CT {
var TestHdlrParams pars := f_gen_test_hdlr_pars();
pars.host_aoip_tla := "::6";
@ -8026,6 +8060,16 @@ runs on MSC_ConnHdlr {
deactivate(ack_rel_req);
}
friend function f_perform_clear_no_lchan()
runs on MSC_ConnHdlr {
f_logp(BSCVTY, "MSC instructs BSC to clear channel");
BSSAP.send(ts_BSSMAP_ClearCommand(0));
BSSAP.receive(tr_BSSMAP_ClearComplete);
f_logp(BSCVTY, "Got BSSMAP Clear Complete");
/* Also drop the SCCP connection */
BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);
}
private function f_perform_clear_test_ct(DchanTuple dt)
runs on test_CT
{
@ -11290,6 +11334,7 @@ control {
execute( TC_ho_into_this_bsc_a5_4() );
execute( TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg() );
execute( TC_ho_into_this_bsc_a5_1_3() );
execute( TC_ho_into_this_bsc_a5_mismatch() );
if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_AoIP) {
execute( TC_ho_into_this_bsc_tla_v6() );
}

6
bsc/MSC_ConnectionHandler.ttcn
View File

@ -670,7 +670,8 @@ type record TestHdlrParams {
boolean exp_fast_return, /* RR Release expected to contain CellSelectInd ? */
boolean expect_channel_mode_modify,
uint3_t expect_tsc optional,
BSSMAP_IE_CellIdentifier cell_id_source
BSSMAP_IE_CellIdentifier cell_id_source,
boolean expect_ho_fail
};
/* Note: Do not use valueof() to get a value of this template, use
@ -710,7 +711,8 @@ template (value) TestHdlrParams t_def_TestHdlrPars := {
exp_fast_return := false,
expect_channel_mode_modify := false,
expect_tsc := omit,
cell_id_source := valueof(ts_CellID_LAC_CI(1, 1))
cell_id_source := valueof(ts_CellID_LAC_CI(1, 1)),
expect_ho_fail := false
}
function f_create_chan_and_exp(template (present) PDU_BSSAP exp_l3_compl := ?)