ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

bsc: Verify presence of MS Power Parameters IE on one test 

Otherwise most tests in bsc-latest fail because in latest release BSC
never sends that IE.

Related: OS#4244
Change-Id: I725836784a7900d2ea51eae188c2c279e8639dbf
This commit is contained in:
Pau Espin 2019-11-05 11:46:53 +01:00 committed by laforge
parent 7a9ccf8df9
commit 8f77363ea3
3 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bsc/BSC_Tests.ttcn
View File

@ -4372,6 +4372,19 @@ testcase TC_chopped_ipa_payload() runs on test_CT {
}
}
/* Verify the BSC sends the MS Power Parameters IE during CHAN ACT to make sure
the BTS does autonomous MS power control loop */
testcase TC_assignment_verify_ms_power_params_ie() runs on test_CT {
var MSC_ConnHdlr vc_conn;
var TestHdlrParams pars := f_gen_test_hdlr_pars();
//pars.encr := valueof(t_EncrParams('01'O, f_rnd_octstring(8)));
pars.exp_ms_power_params := true;
f_init(1, true);
f_sleep(1.0);
vc_conn := f_start_handler(refers(f_tc_assignment_fr_a5), pars);
vc_conn.done;
}
/* Dyn PDCH todo:
* activate OSMO as TCH/F
@ -4541,6 +4554,8 @@ control {
execute( TC_chopped_ipa_ping() );
execute( TC_chopped_ipa_payload() );
/* Power control related */
execute( TC_assignment_verify_ms_power_params_ie() );
/* at bottom as they might crash OsmoBSC before OS#3182 is fixed */
execute( TC_early_conn_fail() );
execute( TC_late_conn_fail() );

4
bsc/MSC_ConnectionHandler.ttcn
View File

@ -527,6 +527,7 @@ type record TestHdlrParams {
TestHdlrParamsLcls lcls,
TestHdlrParamsHandover handover optional,
uint5_t exp_ms_power_level,
boolean exp_ms_power_params,
boolean aoip,
boolean use_osmux
};
@ -553,6 +554,7 @@ template (value) TestHdlrParams t_def_TestHdlrPars := {
},
handover := omit,
exp_ms_power_level := 7, /* calculated from osmo-bsc.cfg "ms max power" */
exp_ms_power_params := false,
aoip := true,
use_osmux := false
}
@ -762,7 +764,7 @@ private function f_check_chan_act(AssignmentState st, RSL_Message chan_act) runs
/* FIXME: validate RSL_IE_ACT_TYPE, RSL_IE_CHAN_MODE, RSL_IE_CHAN_IDENT, RSL_IE_BS_POWER,
* RSL_IE_TIMING_ADVANCE */
if (not f_rsl_find_ie(chan_act, RSL_IE_MS_POWER_PARAM, ms_power_param)) {
if (g_pars.exp_ms_power_params and not f_rsl_find_ie(chan_act, RSL_IE_MS_POWER_PARAM, ms_power_param)) {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "IE MS Power Parameters not found in CHAN ACT");
}

1
bsc/expected-results.xml
View File

@ -102,6 +102,7 @@
<testcase classname='BSC_Tests' name='TC_dyn_pdch_osmo_act_nack' time='MASKED'/>
<testcase classname='BSC_Tests' name='TC_chopped_ipa_ping' time='MASKED'/>
<testcase classname='BSC_Tests' name='TC_chopped_ipa_payload' time='MASKED'/>
<testcase classname='BSC_Tests' name='TC_assignment_verify_ms_power_params_ie' time='MASKED'/>
<testcase classname='BSC_Tests' name='TC_early_conn_fail' time='MASKED'/>
<testcase classname='BSC_Tests' name='TC_late_conn_fail' time='MASKED'/>
<testcase classname='BSC_Tests' name='TC_assignment_codec_amr_f_S1' time='MASKED'/>