ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

fix TC_pdp4_act_deact_with_separate_dns 

Do not delete the PDP context too early, and look for the second DNS
server in the correct place (2nd match on IPCP protocol, not 1st).

Update a comment which talks about a bug which has been fixed.

Change-Id: I109491cc9ccb060792e29bf6b2999ef48723edbf
Related: OS#3319
Related: OS#3381
This commit is contained in:
Stefan Sperling 2018-07-19 19:24:38 +02:00
parent d07ee1396f
commit 8e7a396656
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ggsn_tests/GGSN_Tests.ttcn
View File

@ -1017,11 +1017,10 @@ module GGSN_Tests {
if (not match(pco_neg_dns, pco_neg_dns_expected)) {
setverdict(fail, "Primary DNS IPv4 PCO option not found");
}
f_pdp_ctx_del(ctx, '1'B);
/* Check if secondary DNS is contained */
/* Note: this check fill fail due to a bug in osmo-ggsn, see also OS#3381 */
pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 1);
/* This used to fail due to a bug in osmo-ggsn, see OS#3381 */
pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 2);
pco_neg_dns_expected := '0200000A8306'O & ggsn_ip4_dns2
if (not match(pco_neg_dns, pco_neg_dns_expected)) {
setverdict(fail, "Secondary DNS IPv4 PCO option not found");